bugGnash - The GNU Flash player - Bugs: bug #23477, startStopped is broken

 
 

bug #23477: startStopped is broken

Submitted by:  Deanna Phillips <deanna>
Submitted on:  Wed 04 Jun 2008 03:05:15 AM UTC  
 
Category: gui-gtkSeverity: 5 - Blocker
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Sandro Santilli <strk>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Tue 02 Dec 2008 02:52:18 PM UTC, comment #15:

Works for me. I'd like to improve how it looks, but the serious bugs appear to be fixed.

Benjamin Wolsey <bwy>
Project Member
Tue 18 Nov 2008 03:13:14 PM UTC, comment #14:

I've made the vertical box always used, also when gnash
is embedded in the browser window.
It fixes the startStopped problems for me.
Tests highly welcome.
revision 10295.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Tue 18 Nov 2008 12:42:22 PM UTC, comment #13:

As of revno 10293 the 'click-to-play' widget also works
with the standalone player.
It could be a way to test it.
So far, it seems the way implemented in standalone player
doesn't suffer from this bug.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Tue 18 Nov 2008 10:38:09 AM UTC, comment #12:

I tested this, and seems only related to the GTK gui,
in particular, to the 'click to play' button.
If I drop that, 'startStopped' works fine (ie: as long as you use the menu to resume playback).

I've been using http://www.youtube.com/watch?v=9sJUDx7iEJw
for testing.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Tue 18 Nov 2008 04:07:09 AM UTC, comment #11:

it still happens to me, not every times.

still have to do "Movie Control"->Pause, Play, cycle to get video

Dongxu Li <butdiene>
Mon 03 Nov 2008 01:30:47 PM UTC, comment #10:

It is still broken for me. Just luck that it didn't happen the first few times.

Benjamin Wolsey <bwy>
Project Member
Mon 03 Nov 2008 08:04:16 AM UTC, comment #9:

Please test this now that the initialization order is more sensible and the media handlers are better.

Benjamin Wolsey <bwy>
Project Member
Sun 05 Oct 2008 06:05:49 PM UTC, comment #8:

I believe startStopped is disabled by default, so this won't block the release.

Bastiaan Jacques <bjacques>
Project Member
 Spam posted by an anonymous
 Spam posted by an anonymous
Sat 14 Jun 2008 06:14:56 PM UTC, comment #7:

I believe this may be related to a few other gstreamer issues I've run into.

1, pause mode does not work. It will disable video, but the audio keeps going, and when it's unpaused, the video is still in sync with the audio. In other words, all pause mode does is black out the video.

2, google video always starts with audio playing right away, and video disabled just as I described above. Toggling stop/start re-enables the video. This is not affected by the startup pause mode in any way. I notice that gnash fetches some javascript from google video that tries to pause.

Deanna Phillips <deanna>
Wed 11 Jun 2008 06:56:36 PM UTC, comment #6:

I agree on the needed progress.
Still, working on not based on that is a bug, so please
keep this item for that bug, and maybe open a task for
the road ahead.

nyu on IRC is the author of the patch, btw..

Sandro Santilli <strk>
Project MemberIn charge of this item.
Wed 11 Jun 2008 06:33:49 PM UTC, comment #5:

The fix is to ship with startstopped turned off. It needs work anyway. For example, the message "Click to play" needs to indicate that it's coming from gnash rather than the movie. It also needs to tell people how to turn off startstopped should be desire to ship it turned on. Ideally we would have an exception list which flips the setting. So, if you default to startstopped on, the exception list is a blacklist. If you default to it off, the exception list is a whitelist. Once we've got that, we give people a button for "Always play movies from this site" and "Play this movie just this time." And when they go to the menu, we have two menu items: one for "Startstopped for all sites" and another for "Startstopped for this site".

Russ Nelson <nelsonrn>
Wed 11 Jun 2008 11:31:20 AM UTC, comment #4:

Nelson, what changed triggering the confirmed->ready_for_test
status transition ? Haven't seen any commit about it ..

Sandro Santilli <strk>
Project MemberIn charge of this item.
Mon 09 Jun 2008 08:09:26 PM UTC, comment #3:

Oh, an important note: this is with the new youtube player
(formerly known as "beta", now the only officially available one, can't opt-out anymore from it)

Sandro Santilli <strk>
Project MemberIn charge of this item.
Mon 09 Jun 2008 08:08:43 PM UTC, comment #2:

Alright, I can confirm this is really startStopped related.
Can reproduce with FFMPEG not using threading except
for sound.
Didn't try with the "SWF loader thread" disabled though.

When startStopped is true, a MovieControl->restart fixes
the issue, otherwise, it just works.

Setting this to blocker for the release.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Wed 04 Jun 2008 10:51:10 AM UTC, comment #1:

I belive youtube with GST is very dependent on timings.
You may find that a MovieControl->Restart (or browser reload)
fixes it.
Is a kind of known problem (buffer events).

Sandro Santilli <strk>
Project MemberIn charge of this item.
Wed 04 Jun 2008 03:05:15 AM UTC, original submission:

I notice that sometimes I get audio but no video on youtube - just a white screen where the video should be. The video will appear if I toggle 'Movie Control' -> stop -> start, or remove startStopped from my gnashpluginrc.

This is AGG/gstreamer.

Sample - http://youtube.com/watch?v=zEpeZm_f1Zk

Deanna Phillips <deanna>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by butdiene (Posted a comment)
  • -unavailable- added by bwy (Posted a comment)
  • -unavailable- added by bjacques (Posted a comment)
  • -unavailable- added by nelsonrn (Updated the item)
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by deanna (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 16 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 02 Dec 2008 02:52:18 PM UTCbwyStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Tue 18 Nov 2008 03:13:14 PM UTCstrkSeverity4 - Important=>5 - Blocker
      StatusIn Progress=>Ready For Test
    Tue 18 Nov 2008 12:42:22 PM UTCstrkStatusConfirmed=>In Progress
      Assigned toNone=>strk
    Tue 18 Nov 2008 10:38:09 AM UTCstrkCategoryvideo-gst=>gui-gtk
      StatusReady For Test=>Confirmed
    Mon 03 Nov 2008 08:04:16 AM UTCbwyStatusConfirmed=>Ready For Test
    Mon 13 Oct 2008 10:28:52 AM UTCstrkSummarystartStopped sometimes disables video=>startStopped is broken
    Sun 05 Oct 2008 06:05:49 PM UTCbjacquesSeverity5 - Blocker=>4 - Important
    Wed 11 Jun 2008 06:56:36 PM UTCstrkStatusReady For Test=>Confirmed
    Tue 10 Jun 2008 07:45:23 PM UTCnelsonrnStatusConfirmed=>Ready For Test
    Mon 09 Jun 2008 08:08:43 PM UTCstrkSeverity3 - Normal=>5 - Blocker
      StatusNone=>Confirmed
    Wed 04 Jun 2008 10:51:10 AM UTCstrkCategoryNone=>video-gst

    Back to the top


    Powered by Savane 3.1-cleanup1