bugGnash - The GNU Flash player - Bugs: bug #23419, gnash-cvs(05/28/08) doesn't build...

 
 

bug #23419: gnash-cvs(05/28/08) doesn't build with boost-1.35.0

Submitted by:  Dongxu Li <butdiene>
Submitted on:  Wed 28 May 2008 10:38:51 PM UTC  
 
Category: NoneSeverity: 4 - Important
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Sandro Santilli <strk>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 28 May 2008 11:30:03 PM UTC, comment #4:

01:26 < dli> strk, works

Sandro Santilli <strk>
Project MemberIn charge of this item.
Wed 28 May 2008 10:55:21 PM UTC, comment #3:

Committed a fix, please test.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Wed 28 May 2008 10:47:24 PM UTC, comment #2:

http://www.boost.org/users/news/version_1_35_0

and it was: 'boost::defer_lock' instead of 'false'

Sandro Santilli <strk>
Project MemberIn charge of this item.
Wed 28 May 2008 10:45:26 PM UTC, comment #1:

00:42 < Adrinael> strk, nowadays it is done by passing boost::defer_lock_type as the second parameter, instead of true.

.. since we have a few uses of these expliclty locked
mutexes, we might want to have a generic support for it.

Still, I'm not sure the ones in asobj/ really need
that explicit locking (would need a close review).

Sandro Santilli <strk>
Project MemberIn charge of this item.
Wed 28 May 2008 10:38:51 PM UTC, original submission:

gnash-cvs(05/28/08) and boost-1.35.0

error messages:

/bin/sh ../libtool --tag=CXX --mode=compile x86_64-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I.. -DPLUGINSDIR=\"/usr/lib/gnash/plugins\" -DSYSCONFDIR=\"/etc\" -I.. -I. -I.. -I../libnet -I../libamf -I../server -I../server/swf -pthread -I/usr/include/libxml2 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -pthread -I/usr/include/gstreamer-0.10 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libxml2 -I/usr/X11R6/include -O3 -march=core2 -fomit-frame-pointer -fexpensive-optimizations -pipe -pthread -pthread -W -Wall -Wcast-align -Wcast-qual -Wpointer-arith -Wreturn-type -fvisibility-inlines-hidden -MT libgnashbase_la-BitsReader.lo -MD -MP -MF .deps/libgnashbase_la-BitsReader.Tpo -c -o libgnashbase_la-BitsReader.lo `test -f 'BitsReader.cpp' || echo './'`BitsReader.cpp
curl_adapter.cpp: In constructor ‘curl_adapter::CurlSession::CurlSession()’:
curl_adapter.cpp:181: error: no matching function for call to ‘boost::unique_lock<boost::mutex>::unique_lock(boost::mutex&, bool)’
/usr/include/boost/thread/locks.hpp:524: note: candidates are: boost::unique_lock<Mutex>::unique_lock(boost::detail::thread_move_t<boost::upgrade_lock<Mutex> >) [with Mutex = boost::mutex]
/usr/include/boost/thread/locks.hpp:86: note: boost::unique_lock<Mutex>::unique_lock(boost::detail::thread_move_t<boost::unique_lock<Mutex> >) [with Mutex = boost::mutex]

strk> no, I guess I'll need to wrap those mutex again in a custom class
<strk> I did it before, then when I found that second argument existed, I wiped everything out
<strk> dammit
<strk> now I want it back
<strk> (abstraction of abstraction)
<strk> class Mutex { void lock(); void unlock(); .... }
<strk> ;
<strk> would be using a single boost::mutex in 1.35 and a mutex/scoped_lock for < 1.35

Dongxu Li <butdiene>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by butdiene (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 28 May 2008 11:30:03 PM UTCstrkStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Wed 28 May 2008 10:55:21 PM UTCstrkStatusNone=>Ready For Test
    Wed 28 May 2008 10:45:26 PM UTCstrkSeverity3 - Normal=>4 - Important
      Assigned toNone=>strk

    Back to the top


    Powered by Savane 3.1-cleanup1