bugGnash - The GNU Flash player - Bugs: bug #23323, Regression in Bejeweled.swf

 
 

bug #23323: Regression in Bejeweled.swf

Submitted by:  Benjamin Wolsey <bwy>
Submitted on:  Fri 23 May 2008 06:52:57 AM UTC  
 
Category: NoneSeverity: 4 - Important
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Sandro Santilli <strk>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

 Spam posted by an anonymous
Tue 22 Jul 2008 07:20:57 PM UTC, comment #4:

I can confirm the fix to the regression.

Benjamin Wolsey <bwy>
Project Member
Tue 22 Jul 2008 05:56:58 PM UTC, comment #3:

Committed revision 9519 with these fixes:

1: have setTextFormat query font from the relative SWF movie rather then the global shared font lib.
2: trim trailing nulls when reading strings with length.

Fonts lookup needs some more attention.
In particular, we should have a kind of scope chain there too,
as loaded movies should have access to fonts defined in loaders.
See http://wiki.gnashdev.org/SharedFonts.

Anyway, not to do with this particular bug.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Tue 22 Jul 2008 01:06:05 PM UTC, comment #2:

So, the triggering change was added support for setTextFormat.
The movie uses it to request for a font 'Arial'.
That lookup fails for more then a reason:

1) gnash reads the font name (in DefineFont2) with a read_string_with_length, which in this case has a length that includes the terminating null - you can see with -vp that the name is printed as 'Arial@'

2) DefineFont2 tag loader does NOT register read fonts to the global fontlib, but just to the movie_definition. edit_text_character queries the global fontlib instead.

Sounds like we'll need some fun with testcases

Sandro Santilli <strk>
Project MemberIn charge of this item.
Sun 29 Jun 2008 10:18:36 PM UTC, comment #1:

0.8.2 showed the text, 0.8.3 doesn't.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Fri 23 May 2008 06:52:57 AM UTC, original submission:

The text isn't shown any more in the attached movie. There are XML errors, this error repeatedly:

DEBUG: Unloaded TextField in registered textfield variables container on ::markReachableResources

and some absent glyph messages:

MALFORMED SWF: void gnash::edit_text_character::format_text() -- missing embedded glyph for char 84. Make sure character shapes for font Arial are being exported into your SWF file.

It's not very clear which one is responsible, if any.

(Put both files in the same directory to test).

Benjamin Wolsey <bwy>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #15708:  Bejeweled.swf added by bwy (212KiB - application/x-shockwave-flash)
file #15709:  bejeweled.xml added by bwy (28KiB - text/xml)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by bwy (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 22 Jul 2008 09:47:12 PM UTCstrkStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Tue 22 Jul 2008 01:06:05 PM UTCstrkStatusConfirmed=>In Progress
      Assigned toNone=>strk
    Sun 29 Jun 2008 10:18:36 PM UTCstrkSeverity3 - Normal=>4 - Important
      StatusNone=>Confirmed
    Fri 23 May 2008 06:52:57 AM UTCbwyAttached File-=>Added Bejeweled.swf, #15708
      Attached File-=>Added bejeweled.xml, #15709

    Back to the top


    Powered by Savane 3.1-cleanup1