bugGNU Wget - Bugs: bug #23266, --ask-password should bail if it...

 
 

bug #23266: --ask-password should bail if it returns a null password

Submitted by:  Micah Cowan <micahcowan>
Submitted on:  Fri 16 May 2008 05:53:26 AM UTC  
 
Category: Program LogicSeverity: 4 - Important
Priority: 7 - HighStatus: Fixed
Privacy: PublicAssigned to: None
Originator Name: Open/Closed: Closed
Release: NoneOperating System: None
Reproducibility: NoneFixed Release: 1.12
Planned Release: 1.12Regression: None
Work Required: NonePatch Included: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 17 May 2008 08:03:21 PM UTC, comment #3:

Addressed for mainline in 5952f912bb63.

Micah Cowan <micahcowan>
Sat 17 May 2008 07:47:28 PM UTC, comment #2:

Nothing wrong: I frequently submit reports even for trivial code changes, so they're tracked and I'm sure to get to them eventually. :)

Note that a check against NULL would also be necessary, as that is returned for some errors.

Micah Cowan <micahcowan>
Fri 16 May 2008 09:47:57 PM UTC, comment #1:

Is there something wrong with the following code?

if (opt.ask_passwd)
{
opt.passwd = prompt_for_password ();

if(!strlen(opt.passwd))
{
exit(1);
}
}

It works for CTRL+D and empty input, obviously. What other cases do you mean with 'etc.'?

Joao Fernando Ferreira <jff>
Fri 16 May 2008 05:53:26 AM UTC, original submission:

Say, when Control-D is entered, etc. No further message should be given.

Micah Cowan <micahcowan>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jff (Posted a comment)
  • -unavailable- added by micahcowan (Submitted the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 17 May 2008 08:03:20 PM UTCmicahcowanStatusConfirmed=>Fixed
      Open/ClosedOpen=>Closed
      Fixed ReleaseNone=>1.12
    Fri 16 May 2008 06:19:22 AM UTCmicahcowanPriority5 - Normal=>7 - High

    Back to the top


    Powered by Savane 3.1-cleanup1