bugGNU Wget - Bugs: bug #23238, --no-clobber doesn't work with -O...

 
 

bug #23238: --no-clobber doesn't work with -O flag

Submitted by:  Mark Tomich <metuchen>
Submitted on:  Mon 12 May 2008 04:42:04 PM UTC  
 
Category: Program LogicSeverity: 2 - Minor
Priority: 9 - ImmediateStatus: Fixed
Privacy: PublicAssigned to: None
Originator Name: Open/Closed: Closed
Release: 1.11.1Operating System: GNU/Linux
Reproducibility: Every TimeFixed Release: 1.12
Planned Release: 1.12Regression: Yes
Work Required: NonePatch Included: Yes

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Fri 22 Aug 2008 11:56:54 PM UTC, comment #11:

Test for mainline in 419c27cecfc5.

Micah Cowan <micahcowan>
Mon 30 Jun 2008 04:43:29 AM UTC, comment #10:

Fixed for 1.11.4 in 19e892e84590.
Retargeting for 1.12 for a test to be written.

Micah Cowan <micahcowan>
Tue 17 Jun 2008 05:54:31 PM UTC, comment #9:

Yeah, sorry. I thought I'd tested this with 1.10.2, and gotten the same behavior. But, I may have used /usr/bin/wget from work, which is a Red Hat-modified version, which could have thrown me off. Anyway...

Micah Cowan <micahcowan>
Tue 17 Jun 2008 05:51:26 PM UTC, comment #8:

I agree that it is a regression...primarily because the behavior is different from previous versions...but I can see it either way so I didn't fight it.

Mark Tomich <metuchen>
Tue 17 Jun 2008 05:41:02 PM UTC, comment #7:

Also, I may have been wrong: it may have been a regression after all. Canonical 1.10.2 behavior appears to be that Wget always downloads, regardless of -nc. The fix looks better, to me: honors -nc properly.

Micah Cowan <micahcowan>
Tue 17 Jun 2008 05:39:24 PM UTC, comment #6:

Retargeting for a possible 'nother 1.11.x release.

Micah Cowan <micahcowan>
Fri 16 May 2008 06:30:38 AM UTC, comment #5:

Resolved for mainline in 85298083bf02.

Micah Cowan <micahcowan>
Wed 14 May 2008 10:17:22 PM UTC, comment #4:

Patch was submitted via IRC; jff will upload it later.

Micah Cowan <micahcowan>
Mon 12 May 2008 05:47:52 PM UTC, comment #3:

Fair enough.

Micah Cowan <micahcowan>
Mon 12 May 2008 05:29:30 PM UTC, comment #2:

I think --no-clobber should be allowed to be combined with -O, but if the file specified in -O exists, it should exit.

Mark Tomich <metuchen>
Mon 12 May 2008 05:13:22 PM UTC, comment #1:

-O does not specify a directory, it specifies a file, to which all downloaded content will be placed.

--no-clobber seems a very odd switch to use in combination with -O, considering any clobbering will have been done before Wget even starts to connect. But yeah, it shouldn't do its no-clobber checks anywhere other than at the start, when -O is used.

Perhaps --no-clobber should simply be disallowed, as -N and -O currently are.

Setting Regression -> No on this report, since 1.10.2 exhibits the same behavior.

Micah Cowan <micahcowan>
Mon 12 May 2008 04:42:04 PM UTC, original submission:

If you specify the --no-clobber switch with the -O option to specify the output directory, it will invariably not download the file reporting "file already there".

e.g.:

# rm /tmp/foo
# ls -l /tmp/foo
ls: cannot access /tmp/foo: No such file or directory
# wget --version
GNU Wget 1.11.1
...
# wget --no-clobber -O /tmp/foo http://gnu.org
File `/tmp/foo' already there; not retrieving.
# ls -l /tmp/foo
-rw-r--r-- 1 root root 0 May 12 12:39 /tmp/foo

Mark Tomich <metuchen>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #15665:  23238.patch added by jff (6KiB - text/x-diff - JFF's patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jff (Updated the item)
  • -unavailable- added by micahcowan (Posted a comment)
  • -unavailable- added by metuchen (Submitted the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 23 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 22 Aug 2008 11:56:54 PM UTCmicahcowanOpen/ClosedOpen=>Closed
    Fri 22 Aug 2008 11:56:53 PM UTCmicahcowanStatusReady For Test=>Fixed
    Mon 30 Jun 2008 04:43:29 AM UTCmicahcowanPriority5 - Normal=>9 - Immediate
      StatusConfirmed=>Ready For Test
      Planned Release1.11.4=>1.12
    Tue 17 Jun 2008 05:41:02 PM UTCmicahcowanRegressionNo=>Yes
    Tue 17 Jun 2008 05:39:24 PM UTCmicahcowanStatusFixed=>Confirmed
      Open/ClosedClosed=>Open
      Planned Release1.12=>1.11.4
    Fri 16 May 2008 06:30:38 AM UTCmicahcowanStatusReady for Merge=>Fixed
      Assigned tomicahcowan=>None
      Open/ClosedOpen=>Closed
      Fixed ReleaseNone=>1.12
    Wed 14 May 2008 10:26:11 PM UTCjffAttached File-=>Added 23238.patch, #15665
    Wed 14 May 2008 10:17:22 PM UTCmicahcowanStatusConfirmed=>Ready for Merge
      Assigned tojff=>micahcowan
      Planned Release1.15=>1.12
      Patch IncludedNone=>Yes
    Wed 14 May 2008 08:44:48 PM UTCjffAssigned toNone=>jff
    Mon 12 May 2008 05:13:22 PM UTCmicahcowanSeverity3 - Normal=>2 - Minor
      StatusNone=>Confirmed
      Planned ReleaseNone=>1.15
      RegressionYes=>No

    Back to the top


    Powered by Savane 3.1-cleanup1