bugGnash - The GNU Flash player - Bugs: bug #23214, fails to build with gcc 4.3

 
 

bug #23214: fails to build with gcc 4.3

Submitted by:  Robert Millan <robertmh>
Submitted on:  Fri 09 May 2008 12:23:36 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sun 11 May 2008 07:36:04 PM UTC, comment #8:

The original reporter confirmed head builds fine now.

Sandro Santilli <strk>
Project Member
Fri 09 May 2008 08:18:17 PM UTC, comment #7:

I also only replied cause gcc 4.3 and 4.4 have always been working for me just fine. So maybe Debian is stuck with a one line ugly patch. I think we have string.h in other files though, if you get an urge to eliminate them all...

Rob Savoye <rsavoye>
Project Administrator
Fri 09 May 2008 08:15:11 PM UTC, comment #6:

Since cstring is already included, I guess we're all in agreement, then.

Not really sure why I replied to this bug anyway; I think it was seeing the patch that made my blood boil.

Benjamin Wolsey <bwy>
Project Member
Fri 09 May 2008 08:06:35 PM UTC, comment #5:

"a string header", not string.h. If cstring doesn't work, then Debian has a compiler problem...

Rob Savoye <rsavoye>
Project Administrator
Fri 09 May 2008 08:03:24 PM UTC, comment #4:

<string.h> is deprecated for a reason in favour of cstring, surely. And it would reintroduce one of those compiler warnings we're trying to get rid of. And thirdly, if it fails genuinely with a legitimate compiler, there must be another error in the code.

But it's a bug reported before 0.8.2 was released, so we should surely leave our code as it is (it's been tested on enough compilers) and Debian should stop using that horrible patch and have a bit of confidence in Gnash :)

Benjamin Wolsey <bwy>
Project Member
Fri 09 May 2008 07:47:06 PM UTC, comment #3:

I build with GCC 4.4 on several platforms without a problem, but I don't think including a string header is going to cause any problems, so if it helps on some platforms, it might as well be added.

Rob Savoye <rsavoye>
Project Administrator
Fri 09 May 2008 07:44:37 PM UTC, comment #2:

I build with g++4.3, and have never had this problem. Including string.h is never a fix to C++ code...

Benjamin Wolsey <bwy>
Project Member
Fri 09 May 2008 01:10:00 PM UTC, comment #1:

plugin.cpp includes <cstring> already, which should be
equivalent of <string.h> but extern "C" wrapped

Sandro Santilli <strk>
Project Member
Fri 09 May 2008 12:23:36 PM UTC, original submission:

See:

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=455395

The fix is trivial, see:

http://svn.debian.org/viewsvn/pkg-flash/packages/gnash/trunk/debian/patches/

Robert Millan <robertmh>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rsavoye (Posted a comment)
  • -unavailable- added by bwy (Posted a comment)
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by robertmh (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 11 May 2008 07:36:04 PM UTCstrkStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Fri 09 May 2008 01:10:00 PM UTCstrkStatusNone=>Ready For Test

    Back to the top


    Powered by Savane 3.1-cleanup1