bugGnash - The GNU Flash player - Bugs: bug #23076, regression between 2008-04-08 and...

 
 

bug #23076: regression between 2008-04-08 and 2008-04-09, xml parsning

Submitted by:  Fredrik Johansson <mumme>
Submitted on:  Sun 27 Apr 2008 01:35:18 PM UTC  
 
Category: coreSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Sandro Santilli <strk>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon 28 Apr 2008 09:09:30 PM UTC, comment #8:

Yes it works for me again now, thanks!

/ Fredrik

Fredrik Johansson <mumme>
Mon 28 Apr 2008 11:35:43 AM UTC, comment #7:

Fixes it for me.

Benjamin Wolsey <bwy>
Project Member
Mon 28 Apr 2008 10:35:41 AM UTC, comment #6:

Ready for test, we were blindly trusting advertised
stream size (which was bogusly returned by HTTP server in this case)

Sandro Santilli <strk>
Project MemberIn charge of this item.
Mon 28 Apr 2008 10:03:09 AM UTC, comment #5:

Well, it seems the XML is NOT malformed, but turns malformed
as truncated by the downloader thread.
Origins are likely in the HTTP header reporting wrong size
of the file... Working on it.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Mon 28 Apr 2008 09:46:22 AM UTC, comment #4:

Other automated test failing (with RECOVER) is:
testsuite/actionscript.all/XML.as:717

Sandro Santilli <strk>
Project MemberIn charge of this item.
Mon 28 Apr 2008 09:44:08 AM UTC, comment #3:

Unfortunately, the RECOVER flag triggers failure
in other expected results. In particular, there's an automated
one in swfdec testsuite:
string-object-tostring

Sandro Santilli <strk>
Project MemberIn charge of this item.
Mon 28 Apr 2008 09:35:48 AM UTC, comment #2:

Indeed passing the RECOVER flag to first-time parsing
makes it go further...

Sandro Santilli <strk>
Project MemberIn charge of this item.
Mon 28 Apr 2008 09:33:21 AM UTC, comment #1:

I get an: ERROR: recovered malformed XML.
Doesn't by itself tell if interpretation was correct though.
Did it really use to work or just didn't complain about those
malformations ?

Sandro Santilli <strk>
Project MemberIn charge of this item.
Sun 27 Apr 2008 01:35:18 PM UTC, original submission:

cvs head from 2008-04-08 works fine here:
$ gnash -U 'http://www.sf.se/filmer/film?filmid=16002535' -P 'flashvars=movieid=16002535&filmid=16002535&cityid=VO&genres=Drama,Action,aventyr,Svensk,&xmlPath=http://www.sf.se:80/DataProvider' http://www.sf.se/sf/component/trailerplayer/sfPlayer.swf

but after commit:
http://cvs.savannah.gnu.org/viewvc/gnash/server/asobj/xml.cpp?root=gnash&r1=1.77&r2=1.78

It fails with with this debug info on command line:
$ gnash -U 'http://www.sf.se/filmer/film?filmid=16002535' -P 'flashvars=movieid=16002535&filmid=16002535&cityid=VO&genres=Drama,Action,aventyr,Svensk,&xmlPath=http://www.sf.se:80/DataProvider' http://www.sf.se/sf/component/trailerplayer/sfPlayer.swf
Entity: line 19: parser error : attributes construct error
<movie link="/filmer/film?filmid=16002576" name="27 dresses"/
^
Entity: line 19: parser error : Couldn't find end of Start Tag movie line 19
<movie link="/filmer/film?filmid=16002576" name="27 dresses"/
^
Entity: line 19: parser error : Premature end of data in tag movies line 17
<movie link="/filmer/film?filmid=16002576" name="27 dresses"/
^
Entity: line 19: parser error : Premature end of data in tag movie line 4
<movie link="/filmer/film?filmid=16002576" name="27 dresses"/
^
Entity: line 19: parser error : Premature end of data in tag movies line 3
<movie link="/filmer/film?filmid=16002576" name="27 dresses"/
^
Entity: line 1: parser error : XML declaration allowed only at the start of the document
<?xml version="1.0" encoding="utf-8"?>
^
Entity: line 19: parser error : attributes construct error
<movie link="/filmer/film?filmid=16002576" name="27 dresses"/
^
Entity: line 19: parser error : Couldn't find end of Start Tag movie line 19
<movie link="/filmer/film?filmid=16002576" name="27 dresses"/
^
Entity: line 19: parser error : Premature end of data in tag movies line 17
<movie link="/filmer/film?filmid=16002576" name="27 dresses"/
^
Entity: line 19: parser error : Premature end of data in tag movie line 4
<movie link="/filmer/film?filmid=16002576" name="27 dresses"/
^
Entity: line 19: parser error : Premature end of data in tag movies line 3
<movie link="/filmer/film?filmid=16002576" name="27 dresses"/
^
Entity: line 19: parser error : chunk is not well balanced
<movie link="/filmer/film?filmid=16002576" name="27 dresses"/
^

It is still an issue in todays, 2008-04-27, HEAD. Which is why I regressiontested it to that commit.

my make dumpconfig
$ make dumpconfig

Building in directories: libbase libgeometry libamf libnet libmedia server backend utilities gui plugin pythonmodule doc po testsuite
Some directories may be excluded from the build
Linux linux64 2.6.24-16-generic #1 SMP Thu Apr 10 12:47:45 UTC 2008 x86_64 GNU/Linux
g++ -v
Använder inbyggda specifikationer.
Mål: x86_64-linux-gnu
Konfigurerad med: ../src/configure -v --enable-languages=c,c++,fortran,objc,obj-c++,treelang --prefix=/usr --enable-shared --with-system-zlib --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --enable-nls --with-gxx-include-dir=/usr/include/c++/4.2 --program-suffix=-4.2 --enable-clocale=gnu --enable-libstdcxx-debug --enable-objc-gc --enable-mpfr --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu
Trådmodell: posix
gcc version 4.2.3 (Ubuntu 4.2.3-2ubuntu7)
CXXFLAGS: -g -O2 -pthread -pthread -W -Wall -Wcast-align -Wcast-qual -Wpointer-arith -Wreturn-type -fvisibility-inlines-hidden

Image decoding support...
JPEG_CFLAGS is
JPEG_LIBS is -ljpeg
PNG_CFLAGS is
PNG_LIBS is -lpng12
Audio decoding support...
GSTREAMER_CFLAGS is -pthread -I/usr/include/gstreamer-0.10 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2
GSTREAMER_LIBS is -lgstreamer-0.10 -lgobject-2.0 -lgmodule-2.0 -ldl -lgthread-2.0 -lrt -lxml2 -lglib-2.0 -lgstpbutils-0.10
GUI Toolkit decoding support...
SDL_CFLAGS is
SDL_LIBS is
KDE_CFLAGS is -I/usr/include/kde -I/usr/include/kde/kio
KDE_LIBS is -lkdeui -lkdecore -lkdeprint
GTK2_CFLAGS is -DPNG_NO_MMX_CODE -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/pixman-1
GTK2_LIBS is -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgdk_pixbuf-2.0 -lm -lpangocairo-1.0 -lpango-1.0 -lcairo -lgobject-2.0 -lgmodule-2.0 -ldl -lglib-2.0
PANGO_CFLAGS is -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
PANGO_LIBS is -lpangox-1.0 -lX11 -lpango-1.0 -lgobject-2.0 -lgmodule-2.0 -ldl -lglib-2.0
ATK_CFLAGS is -I/usr/include/atk-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
ATK_LIBS is -latk-1.0 -lgobject-2.0 -lgmodule-2.0 -ldl -lglib-2.0
X11_CFLAGS is -I/usr/include
X11_LIBS is -lX11 -lXinerama -lXext -lSM -lICE
Support libraries...
INCLTDL
LIBLTDL -lltdl
GLIB_CFLAGS is -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
GLIB_LIBS is -lglib-2.0
Z_CFLAGS is
Z_LIBS is -lz
LIBXML_CFLAGS is -I/usr/include/libxml2
LIBXML_LIBS is -lxml2
FREETYPE_CFLAGS is -I/usr/include/freetype2
FREETYPE_LIBS is -lfreetype -lz
FONTCONFIG_CFLAGS is
FONTCONFIG_LIBS is -lfontconfig
PTHREAD_CFLAGS is -pthread
PTHREAD_LIBS is -lpthread
CURL_CFLAGS is
CURL_LIBS is -lcurl
BOOST_CFLAGS is -I/usr/include
BOOST_LIBS is -L/usr/lib64 -lboost_thread-gcc42-mt-1_34_1 -lboost_date_time-gcc42-1_34_1
BOOST_EXTRA_LIBS is -lboost_serialization-gcc42-1_34_1
Graphics support...
AGG_CFLAGS is -I/usr/include/agg2
AGG_LIBS is -lagg_pic -lagg_pic

A blank value for CFLAGS means the header is installed in the
default system header location. All the LIBS should have a
legit value

Configurable options are:
Media handler: gst
Renderer engine: agg
Supported GUI: GTK
Supported GUI: KDE
Security features enables are: localconnection
Statistics features enables are: queues
KPARTS (KDE) plugin enabled
KPARTS plugin install dir: /home/fredrikjohansson/.kde/lib/kde3
KPARTS service install dir: /home/fredrikjohansson/.kde/share/services
KPARTS config dir: /home/fredrikjohansson/.kde/share/config
KPARTS appsdata dir: /home/fredrikjohansson/.kde/share/apps/klash
NPAPI (Mozilla) plugin enabled
NPAPI plugin install dir: /home/fredrikjohansson/.mozilla/plugins

Hope it helps!

Regards
Fredrik Johansson

Fredrik Johansson <mumme>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bwy (Posted a comment)
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by mumme (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 28 Apr 2008 11:51:57 AM UTCstrkOpen/ClosedOpen=>Closed
    Mon 28 Apr 2008 11:51:56 AM UTCstrkStatusReady For Test=>Fixed
    Mon 28 Apr 2008 10:35:41 AM UTCstrkStatusIn Progress=>Ready For Test
    Mon 28 Apr 2008 10:03:09 AM UTCstrkCategoryNone=>core
      StatusNone=>In Progress
      Assigned toNone=>strk

    Back to the top


    Powered by Savane 3.1-cleanup1