bugGNU Wget - Bugs: bug #23017, simultaneous wget -rbq ftp...

 
 

bug #23017: simultaneous wget -rbq ftp downloads conflict with using the same local .listing

Submitted by:  None
Submitted on:  Tue 22 Apr 2008 10:11:33 AM UTC  
 
Category: Program LogicSeverity: 3 - Normal
Priority: 6Status: Needs Discussion
Privacy: PublicAssigned to: None
Originator Name: B MeneeOriginator Email: -unavailable-
Open/Closed: OpenRelease: None
Operating System: NoneReproducibility: Every Time
Fixed Release: NonePlanned Release: 1.15
Regression: NoneWork Required: 0 - Hours
Patch Included: Yes

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 22 Nov 2008 04:16:52 PM UTC, comment #4:

I just noticed that the message I posted with my latest patch didn't get sent to the CC list with the patch.

In my latest patch, I have extended the PID buffer size to 8 characters as recommended.

Thanks, Saint Xavier.

Derek T. Doyle <derektdoyle>
Tue 14 Oct 2008 07:41:20 AM UTC, comment #3:

Derek, it would be wise to extend PID buffer size to 8 characters for having a full and thus unique PID.

I didn't test the patch so far.

Saint Xavier <sxav>
Mon 13 Oct 2008 09:33:32 PM UTC, comment #2:

OK, I've looked things over and it's pretty clear that I can use concat_strings() to append a dot and the output of getpid() to LIST_FILENAME in ftp_get_listing() in ftp.c, right before the call to file_merge(). This should give us the desired behavior.

This bug seems pretty localized, since LIST_FILENAME isn't used anywhere else, so I'm fairly confident that this is the only necessary coding for the fix.

Unless somebody tells me I've missed something, I'll submit a patch for this soon.

Thanks.

Derek T. Doyle <derektdoyle>
Mon 13 Oct 2008 01:39:56 PM UTC, comment #1:

Hello!

This looks like an interesting bug that I would like to try to fix. May I please have it assigned to me?

I have added myself to the CC list for this bug.

Once I look over the problem and have a fix in mind, I'll post what I'm planning here to make sure I'm not too far off-track.

Thanks.

Derek T. Doyle <derektdoyle>
Tue 22 Apr 2008 10:11:33 AM UTC, original submission:

When I was trying to start multiple ftp downloads in background to the same directory, something like this:
wget -rbq "ftp://1.1.1.1:21/one/"
wget -rbq "ftp://2.2.2.2:21/two/"
wget -rbq "ftp://3.3.3.3:21/three/"
I was having a problem, because wget was using the same local .listing file

It will be better if it will use something like ".listing.{unique-string}" filename, for example ".listing.{pid}" (always or in case in wget see that ".listing" file already exists)

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #16708:  wget_fix_for_bug_23017.2.patch added by derektdoyle (2KiB - text/x-patch - I have extended the PID buffer size to 8 characters as recommended. Thanks, Saint Xavier.)
file #16669:  wget_fix_for_bug_23017.patch added by derektdoyle (2KiB - application/octet-stream - A potential fix for bug 23017 by using unique local .listing files with pid appended so that simultaneous wget -rbq ftp downloads do not conflict.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by sxav (Posted a comment)
  • -unavailable- added by derektdoyle (Posted a comment)
  • -unavailable- added by derektdoyle (Interested in having this one assigned to me.)
  • -unavailable- added by micahcowan (Updated the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 22 Nov 2008 09:46:06 PM UTCmicahcowanStatusConfirmed=>Needs Discussion
      Patch IncludedNone=>Yes
    Mon 20 Oct 2008 11:46:29 AM UTCderektdoyleAttached File-=>Added wget_fix_for_bug_23017.2.patch, #16708
    Tue 14 Oct 2008 12:21:04 AM UTCderektdoyleAttached File-=>Added wget_fix_for_bug_23017.patch, #16669
    Mon 13 Oct 2008 01:39:56 PM UTCderektdoyleCarbon-Copy-=>Added derektdoyle
    Tue 22 Apr 2008 10:33:28 AM UTCmicahcowanPriority5 - Normal=>6
      StatusNone=>Confirmed
      Planned ReleaseNone=>1.15
      Work RequiredNone=>0 - Hours

    Back to the top


    Powered by Savane 3.1-cleanup1