bugGnash - The GNU Flash player - Bugs: bug #22904, regresion: invalidated bounds

 
 

bug #22904: regresion: invalidated bounds

Submitted by:  Sandro Santilli <strk>
Submitted on:  Fri 11 Apr 2008 05:19:49 PM UTC  
 
Category: coreSeverity: 4 - Important
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Sandro Santilli <strk>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Tue 15 Apr 2008 11:17:45 AM UTC, comment #9:

Agree, seems fine.

Udo Giacomozzi <udog>
Project Member
Tue 15 Apr 2008 09:52:11 AM UTC, comment #8:

The specific regression is fixed for me.
I'm sure there are more problems pending, but this bug
can safely be closed for me.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Tue 15 Apr 2008 08:41:05 AM UTC, comment #7:

I guess the culprit is button_character_instance::getBounds:

// TODO: should we consider having multiple characters
// for a single state ?

Of course we do !!

Sandro Santilli <strk>
Project MemberIn charge of this item.
Tue 15 Apr 2008 08:39:26 AM UTC, comment #6:

bounds in clipping area again...

3062847168] 10:38:37 TRACE: 1228: _level0.instance3.instance5 alive
3062847168] 10:38:37 DEBUG: Displaying 2 active childs of button _level0.instance1
3062847168] 10:38:37 DEBUG: Displaying 3 active childs of button _level0.instance3
3062847168] 10:38:38 DEBUG: Character _level0.instance1 bounds not in clipping area, clearing invalidated flag
3062847168] 10:38:38 DEBUG: Displaying 3 active childs of button _level0.instance3
3062847168] 10:38:38 TRACE: 2227: _level0.instance3.instance5 alive
3062847168] 10:38:38 DEBUG: Displaying 2 active childs of button _level0.instance1
3062847168] 10:38:38 DEBUG: Character _level0.instance3 bounds not in clipping area, clearing invalidated flag

Sandro Santilli <strk>
Project MemberIn charge of this item.
Tue 15 Apr 2008 08:34:00 AM UTC, comment #5:

Indeed there's a missing call to a button's ::display:

3061900992] 10:33:20 DEBUG: Displaying 2 active childs of button _level0.instance1
3061900992] 10:33:20 DEBUG: Displaying 3 active childs of button _level0.instance3
3061900992] 10:33:21 TRACE: 21187: _level0.instance3.instance5 alive
3061900992] 10:33:21 DEBUG: Displaying 2 active childs of button _level0.instance1
3061900992] 10:33:22 TRACE: 22187: _level0.instance3.instance5 alive
3061900992] 10:33:22 DEBUG: Displaying 2 active childs of button _level0.instance1

Sandro Santilli <strk>
Project MemberIn charge of this item.
Tue 15 Apr 2008 08:29:10 AM UTC, comment #4:

The new View->ShowUpdatedRanges menu of GTK gui is very useful.
It shows that the invalidated ranges are fine, but still
the whole button turns blank for unknown reason. Maybe
the bug is really somewhere else (display?)

Sandro Santilli <strk>
Project MemberIn charge of this item.
Tue 15 Apr 2008 08:05:32 AM UTC, comment #3:

Reverted my patch as per Udo's request. We're not supposed
to check our own m_child_invalidated, looks like..

Sandro Santilli <strk>
Project MemberIn charge of this item.
Fri 11 Apr 2008 09:59:46 PM UTC, comment #2:

To reproduce next problem:
put the mouse pointer inside the green rectangle on top
and wait to see what happens.
The while rectangle turns blank when the cirlce reaches
half the way, then gets back when it restarts.
With mouse pointer outside, there's no such problem.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Fri 11 Apr 2008 06:31:20 PM UTC, comment #1:

one problem was in not checking m_child_invalidated.
There are others it seems, and code surely doesn't look
right. Check the TODO items I added in last commit there.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Fri 11 Apr 2008 05:19:49 PM UTC, original submission:

swf5/btntest2.swf

Udo, you made that test some time ago.
Attached, in case you can't find it anymore.

Moving the mouse inside the green rectangles
trigger buts in invalidated bounds detection.

Sandro Santilli <strk>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #15447:  btntest2.swf added by strk (1KiB - application/x-shockwave-flash)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by udog (Posted a comment)
  • -unavailable- added by strk (Submitted the item)
  • -unavailable- added by strk
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 15 Apr 2008 11:25:01 AM UTCstrkStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Tue 15 Apr 2008 09:52:11 AM UTCstrkCategoryNone=>core
      StatusNone=>Ready For Test
      Assigned toNone=>strk
    Fri 11 Apr 2008 05:19:49 PM UTCstrkAttached File-=>Added btntest2.swf, #15447
      Carbon-Copy-=>Added udog

    Back to the top


    Powered by Savane 3.1-cleanup1