bugGnash - The GNU Flash player - Bugs: bug #22603, cvs 2008-03-15 fails to build...

 
 

bug #22603: cvs 2008-03-15 fails to build error in debugger.cpp:375

Submitted by:  Fredrik Johansson <mumme>
Submitted on:  Sat 15 Mar 2008 08:48:51 AM UTC  
 
Category: buildSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 15 Mar 2008 09:51:32 AM UTC, comment #3:

Yes it works fine with your patch.

I didn't know about the debugger leak, thanks for the tip.
I'l leave it out on the next configure.

Regards
Fredrik Johansson

Fredrik Johansson <mumme>
Sat 15 Mar 2008 09:41:14 AM UTC, comment #2:

committed a fix.

Sandro Santilli <strk>
Project Member
Sat 15 Mar 2008 09:09:50 AM UTC, comment #1:

Please try the attached patch.
Note that the debugger makes the code leak with no advantage
unless you actually use it (it's not any automatic thing).

(file #15268)

Sandro Santilli <strk>
Project Member
Sat 15 Mar 2008 08:48:51 AM UTC, original submission:

Modifying debugger.cpp makes as below makes it compile for me.

Index: debugger.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/debugger.cpp,v
retrieving revision 1.25
diff -r1.25 debugger.cpp
375c375
< hexify(num, (const unsigned char *)&data[3 + i], 1, false);
---

> hexify(num, (size_t)&data[3 + i], false);


my make dumpconfig:
$ make dumpconfig

Building in directories: libbase libgeometry libamf libmedia server backend utilities gui plugin pythonmodule doc po testsuite
Some directories may be excluded from the build
Linux linux64 2.6.22-14-generic #1 SMP Tue Feb 12 02:46:46 UTC 2008 x86_64 GNU/Linux
g++ -v
Using built-in specs.
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --enable-languages=c,c++,fortran,objc,obj-c++,treelang --prefix=/usr --enable-shared --with-system-zlib --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --enable-nls --with-gxx-include-dir=/usr/include/c++/4.1.3 --program-suffix=-4.1 --enable-__cxa_atexit --enable-clocale=gnu --enable-libstdcxx-debug --enable-mpfr --enable-checking=release x86_64-linux-gnu
Thread model: posix
gcc version 4.1.3 20070929 (prerelease) (Ubuntu 4.1.2-16ubuntu2)
CXXFLAGS: -g -O2 -pthread -pthread -W -Wall -Wcast-align -Wcast-qual -Wpointer-arith -Wreturn-type

Image decoding support...
JPEG_CFLAGS is
JPEG_LIBS is -ljpeg
PNG_CFLAGS is
PNG_LIBS is -lpng12
Audio decoding support...
GSTREAMER_CFLAGS is -pthread -I/usr/include/gstreamer-0.10 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2
GSTREAMER_LIBS is -lgstreamer-0.10 -lgobject-2.0 -lgmodule-2.0 -ldl -lgthread-2.0 -lrt -lxml2 -lglib-2.0 -lgstpbutils-0.10
GUI Toolkit decoding support...
SDL_CFLAGS is
SDL_LIBS is
KDE_CFLAGS is -I/usr/include/kde -I/usr/include/kde/kio
KDE_LIBS is -lkdeui -lkdecore -lkdeprint
GTK2_CFLAGS is -DPNG_NO_MMX_CODE -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/libpng12
GTK2_LIBS is -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgdk_pixbuf-2.0 -lm -lpangocairo-1.0 -lfontconfig -lXext -lXrender -lXinerama -lXi -lXrandr -lXcursor -lXcomposite -lXdamage -lpango-1.0 -lcairo -lX11 -lXfixes -lgobject-2.0 -lgmodule-2.0 -ldl -lglib-2.0
PANGO_CFLAGS is -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
PANGO_LIBS is -lpangox-1.0 -lpango-1.0 -lgobject-2.0 -lgmodule-2.0 -ldl -lglib-2.0
ATK_CFLAGS is -I/usr/include/atk-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
ATK_LIBS is -latk-1.0 -lgobject-2.0 -lgmodule-2.0 -ldl -lglib-2.0
X11_CFLAGS is -I/usr/include
X11_LIBS is -lX11 -lXinerama -lXext -lSM -lICE
Support libraries...
INCLTDL
LIBLTDL -lltdl
GLIB_CFLAGS is -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
GLIB_LIBS is -lglib-2.0
Z_CFLAGS is
Z_LIBS is -lz
LIBXML_CFLAGS is -I/usr/include/libxml2
LIBXML_LIBS is -lxml2
FREETYPE_CFLAGS is -I/usr/include/freetype2
FREETYPE_LIBS is -lfreetype -lz
FONTCONFIG_CFLAGS is
FONTCONFIG_LIBS is -lfontconfig
PTHREAD_CFLAGS is -pthread
PTHREAD_LIBS is -lpthread
CURL_CFLAGS is
CURL_LIBS is -lcurl
BOOST_CFLAGS is -I/usr/include
BOOST_LIBS is -L/usr/lib64 -lboost_thread-gcc41-mt-1_34_1 -lboost_date_time-gcc41-1_34_1
BOOST_EXTRA_LIBS is -lboost_serialization-gcc41-1_34_1
MING_VERSION_CODE 00030000
MING_LIBS -L/usr/lib -lming
MING_CFLAGS -I/usr/include
MAKESWF /usr/bin/makeswf
MTASC /usr/bin/mtasc
MTASC CLASSPATH /usr/share/ocaml/mtasc/std
SWFMILL /usr/local/bin/swfmill
SWFC /usr/bin/swfc
Graphics support...
AGG_CFLAGS is -I/usr/include/agg2
AGG_LIBS is -lagg_pic -lagg_pic

A blank value for CFLAGS means the header is installed in the
default system header location. All the LIBS should have a
legit value

Configurable options are:
Media handler: gst
Renderer engine: agg
Supported GUI: GTK
Supported GUI: KDE
Security features enables are: localconnection
KPARTS (KDE) plugin enabled
KPARTS plugin install dir: /usr/lib/kde3
KPARTS service install dir: /usr/share/services
KPARTS config dir: /etc/kde3
KPARTS appsdata dir: /usr/share/apps/klash
NPAPI (Mozilla) plugin enabled
NPAPI plugin install dir: /usr/lib/firefox/plugins/

Regards
Fredrik Johansson

Fredrik Johansson <mumme>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #15268:  debugger.patch added by strk (818B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by strk (Updated the item)
  • -unavailable- added by mumme (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 15 Mar 2008 09:41:14 AM UTCstrkStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Sat 15 Mar 2008 09:09:50 AM UTCstrkAttached File-=>Added debugger.patch, #15268

    Back to the top


    Powered by Savane 3.1-cleanup1