bugGnash - The GNU Flash player - Bugs: bug #22465, Non-ASCII characters shown as...

 
 

bug #22465: Non-ASCII characters shown as "?" in command-line tools

Submitted by:  Timo Jyrinki <tjyrinki>
Submitted on:  Mon 03 Mar 2008 12:35:15 PM UTC  
 
Category: guiSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Sandro Santilli <strk>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 08 Mar 2008 05:04:13 PM UTC, comment #2:

Confirm the fix.

Benjamin Wolsey <bwy>
Project Member
Mon 03 Mar 2008 04:55:06 PM UTC, comment #1:

committed in both head and 0.8.2 branch.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Mon 03 Mar 2008 12:35:15 PM UTC, original submission:

Non-ASCII characters, ie. those from translations that have eg. umlaut characters, are shown as "?" in command-line tools. You should be able to see this eg. when calling:

LANG=fi_FI.UTF-8 gnash

With up-to-date compilation from sources (Finnish translation added only yesterday). Output has eg: "k?ytt?: gnash [valitsimet] elokuvatiedosto.swf" instead of correct: "käyttö: gnash [valitsimet] elokuvatiedosto.swf".

The reason is that only LC_MESSAGES is set in the cli tools, instead of LC_ALL that includes eg. LC_CTYPE. I don't know of a reason to use only LC_MESSAGES, but if there is, please tell. I checked that seemingly most other stuff uses always LC_ALL, like coreutils (eg. http://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=blob;f=src/ls.c).

Attached is a patch that changes the set_locale(LC_MESSAGES, "") lines to set_locale(LC_ALL, "") in gnash.cpp and utilities. It fixes the issue for me.

Timo Jyrinki <tjyrinki>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #15162:  gnash_fix_locale_setting2.patch added by tjyrinki (2KiB - text/x-diff - patch to change fix locales setting)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bwy (Posted a comment)
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by tjyrinki (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 08 Mar 2008 05:04:28 PM UTCbwyStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Mon 03 Mar 2008 04:55:06 PM UTCstrkStatusNone=>Ready For Test
      Assigned toNone=>strk
    Mon 03 Mar 2008 12:35:15 PM UTCtjyrinkiAttached File-=>Added gnash_fix_locale_setting2.patch, #15162

    Back to the top


    Powered by Savane 3.1-cleanup1