bugGnash - The GNU Flash player - Bugs: bug #22141, Assorted assertion failures

 
 

bug #22141: Assorted assertion failures

Submitted by:  Benjamin Wolsey <bwy>
Submitted on:  Mon 28 Jan 2008 10:18:56 AM UTC  
 
Category: parserSeverity: 5 - Blocker
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Sandro Santilli <strk>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon 28 Jan 2008 05:39:37 PM UTC, comment #6:

I close this then..

Sandro Santilli <strk>
Project MemberIn charge of this item.
Mon 28 Jan 2008 05:26:06 PM UTC, comment #5:

Forget the last two comments - they're in separate bug items (bug #22150, bug #22152) now.

Benjamin Wolsey <bwy>
Project Member
Mon 28 Jan 2008 04:53:36 PM UTC, comment #4:

This has changed since the parser fix:

../../server/parser/action_buffer.h:84: uint8_t gnash::action_buffer::operator[](size_t) const: assertion »off < m_buffer.size()« failed.

(file #14890)

Benjamin Wolsey <bwy>
Project Member
Mon 28 Jan 2008 04:46:56 PM UTC, comment #3:

This one fails with the attached movie, though (also failed before the parser fixes).

swf/tag_loaders.cpp:927: void gnash::SWF::tag_loaders::button_sound_loader(gnash::stream, gnash::SWF::tag_type, gnash::movie_definition): Assertion »dynamic_cast<button_character_definition*> (chdef)« failed.

(file #14889)

Benjamin Wolsey <bwy>
Project Member
Mon 28 Jan 2008 04:36:54 PM UTC, comment #2:

I can confirm all the SIGABRTs have been fixed (also for a few more SWFs).

Benjamin Wolsey <bwy>
Project Member
Mon 28 Jan 2008 03:18:57 PM UTC, comment #1:

It was due to string reading functions being non-robust.
I found myself touching more things then the required
to fix the bug, so might have introduced other bugs..
tests welcome.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Mon 28 Jan 2008 10:18:56 AM UTC, original submission:

Using zzuf or even swfmill, it's easy to find SWFs that fail this assertion:

stream.cpp:58: unsigned int gnash::stream::read(char*, unsigned
int): assertion »end_pos >= cur_pos« failed

A few crashers are attached.

Benjamin Wolsey <bwy>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #14890:  snoopy_click.zzuf.s442.swf added by bwy (212KiB - application/x-shockwave-flash)
file #14889:  snoopy_click.zzuf.s347.swf added by bwy (212KiB - application/x-shockwave-flash)
file #14884:  toy.zzuf.s1.swf added by bwy (24KiB - application/x-shockwave-flash)
file #14885:  toy.zzuf.s0.swf added by bwy (24KiB - application/x-shockwave-flash)
file #14886:  snoopy_click.zzuf.s296.swf added by bwy (212KiB - application/x-shockwave-flash)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by strk (Updated the item)
  • -unavailable- added by bwy (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 12 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 28 Jan 2008 05:39:37 PM UTCstrkStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Mon 28 Jan 2008 04:53:36 PM UTCbwyAttached File-=>Added snoopy_click.zzuf.s442.swf, #14890
    Mon 28 Jan 2008 04:46:56 PM UTCbwyAttached File-=>Added snoopy_click.zzuf.s347.swf, #14889
      Summaryend_pos >= cur_pos assertion in stream.cpp fails=>Assorted assertion failures
    Mon 28 Jan 2008 03:18:57 PM UTCstrkCategoryNone=>parser
      StatusIn Progress=>Ready For Test
    Mon 28 Jan 2008 11:21:34 AM UTCstrkStatusNone=>In Progress
      Assigned toNone=>strk
    Mon 28 Jan 2008 10:18:56 AM UTCbwyAttached File-=>Added toy.zzuf.s1.swf, #14884
      Attached File-=>Added toy.zzuf.s0.swf, #14885
      Attached File-=>Added snoopy_click.zzuf.s296.swf, #14886

    Back to the top


    Powered by Savane 3.1-cleanup1