bugGnash - The GNU Flash player - Bugs: bug #21907, kde-config returns unusable path

 
 

bug #21907: kde-config returns unusable path

Submitted by:  Rob Savoye <rsavoye>
Submitted on:  Sun 30 Dec 2007 05:15:09 AM UTC  
 
Category: buildSeverity: 5 - Blocker
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Sandro Santilli <strk>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sat 05 Jan 2008 01:36:04 AM UTC, comment #13:

Similar problems with $HOME, should be $(HOME) -- in Makefile style variable, but didn't test the latter. Anyway for sure the former failed. The only working version was /home/strk.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Sat 05 Jan 2008 01:33:54 AM UTC, comment #12:

Use $HOME instead of tilde.

Rob Savoye <rsavoye>
Project Administrator
Sat 05 Jan 2008 01:32:10 AM UTC, comment #11:

Ok, I found automake to generate the install/uninstall rules based on _PLUGIN and _DATA variables.
THere's no way to have a tilde expansion there, given also the DESTDIR prefix.
The only way to tilde-expand would be from ./configure, but initial tests for that failed with the message

cd: ~/.kde: no such directory

... of course the dir exist ..

Sandro Santilli <strk>
Project MemberIn charge of this item.
Sat 05 Jan 2008 12:49:47 AM UTC, comment #10:

Mmm.. just a note, konqueror doesn't find gnash plugin using --with-kde-pluginprefix=~/.kde on my ubuntu 7.10 ...

The problem seems to be interpretation of "~" of course,
not sure if we should support that or not.
I committed a fix for what we do explicitly but it seems
some of the install rules come from an unknown source (not in the Makefile.am).

Sandro Santilli <strk>
Project MemberIn charge of this item.
Fri 04 Jan 2008 04:48:41 PM UTC, comment #9:

Hum, yeah well I don't think I can help you there.
I don't understand how distcheck works, sorry.

/ Fredrik

Fredrik Johansson <mumme>
Fri 04 Jan 2008 01:35:55 PM UTC, comment #8:

Committed your patch, and documented the new switch.
Next thing to figure out is the 'make distcheck' rule,
which would fail due to permissions to write the files
where they default to.. (ie: discard --prefix).

Sandro Santilli <strk>
Project MemberIn charge of this item.
Wed 02 Jan 2008 04:47:58 PM UTC, comment #7:

Thanks for the fast response

With the risk of misunderstanding what you mean, I think that making klash files in specified gnash prefix is a bad idea.
rationale:
If I specify gnash prefix to /usr/local/ and my kde-build-prefix is /opt/kde3 or just /usr then it wont be recognised by konqueror, thus failing to start.

If you meant more of a switch like --with-plugin-dir= then I think I have a patch that works: (might need renaming)
--with-kde-pluginprefix=

with that you should be able to:
./configure --with-kde-pluginprefix=~/.kde

And make konqueror pick up the klash service, at least i hope it will. It does for me with Kubuntu 7.10.

Regards
Fredrik Johansson

(file #14736)

Fredrik Johansson <mumme>
Wed 02 Jan 2008 12:06:06 PM UTC, comment #6:

Thanks Fredrik. I committed your patch and added documentation for the new switches in the manual.
About the single kde switch I'd favor it.
Also, I wonder if we should take the presence of a --prefix
switch to force every file install to fall under the specified
dir. This would fix the 'make distcheck' rule for example,
and ensure you won't install anything outside of your specified
--prefix (if you specified any).

Sandro Santilli <strk>
Project MemberIn charge of this item.
Wed 02 Jan 2008 11:33:04 AM UTC, comment #5:

Hi All,

Klash still don't install all files in the correct places if you set prefix to other than kde build prefix.

The folder 'klash' in apps dir, the one that contains 'klashpartui.rc' and 'pluginsinfo' is install at /usr/local/share/apps/klash by default, in my system it should be /usr/share/apps/klash

I attach a patch which adds to more switches (and autofind) to configure, but perhaps there should be a single '--with-klash-prefix=[$HOME/.kde]' also/instead.

In any case as you wondered #strk I managed to get konqueror to pick up klash from my $HOME folder with this patch using:
./configure --prefix=$HOME/Source/gnash/debug --with-kde-servicesdir=$HOME/.kde/share/services --with-kde-appsdatadir=$HOME/.kde/share/apps/klash --with-kde-configdir=$HOME/.kde/share/config --with-kde-plugindir=$HOME/.kde/lib --disable-nsapi

It probably needs some tweaking though, maybe one switch to rule them all would be better.

Oh and a late Happy new Year to you all.

Regards
Fredrik Johansson

(file #14732)

Fredrik Johansson <mumme>
Sun 30 Dec 2007 10:46:10 AM UTC, comment #4:

The kparts one is gone, next could be the NPAPI one, which I belive is still being installed in the wrong directory (firefox-specific rather then mozilla-generic and user-wide rather then systemwide)

Sandro Santilli <strk>
Project MemberIn charge of this item.
Sun 30 Dec 2007 10:17:01 AM UTC, comment #3:

I'm doing the configure part..

Sandro Santilli <strk>
Project MemberIn charge of this item.
Sun 30 Dec 2007 10:02:16 AM UTC, comment #2:

Ah, another thing... if you look at the wiki, you can see that it doesn't contain info about how to make konqueror work with the kparts plugin installed in arbitrary places.

If you don't want to --disable-kparts and don't want it installed
in the official location, does that mean you konw how to make it work loading from arbitrary location ? If so I'd be interested in knowing how, for testing in general (I dont' like having to install gnash system-wide in order to test it either)

Sandro Santilli <strk>
Project MemberIn charge of this item.
Sun 30 Dec 2007 09:39:57 AM UTC, comment #1:

Yes, I'm aware of this.
The solution would be moving the kde-config calls in the
configure script to use as a default and provide override
switches to specify an alternate installation path for the .{lo,la}
and the .desktop file (two different patsh/switches).

See http://wiki.gnashdev.org/wiki/index.php/Gnash_Tips#Questions
for more info.

See also https://savannah.gnu.org/task/?7340 for a related issue with the NPAPI plugin.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Sun 30 Dec 2007 05:15:09 AM UTC, original submission:

/usr/bin/kde-config --install services --expandvars on my system returns /usr/share/services, so "make install" fails because as a user I don't have write permissions to this directory. This will only work if you are root, or don't build the KDE GUI. The full error message is:

test -z "/work/rob/build/gnash/gnash-cvs/_inst/share/apps/klash" || mkdir -p -- "/work/rob/build/gnash/gnash-cvs/_inst/share/apps/klash"
/usr/bin/install -c -m 644 '../../../plugin/klash/pluginsinfo' '/work/rob/build/gnash/gnash-cvs/_inst/share/apps/klash/pluginsinfo'
test -z "`/usr/bin/kde-config --install services --expandvars` " || mkdir -p -- "`/usr/bin/kde-config --install services --expandvars` "
mkdir: cannot create directory `/usr/share/services ': Permission denied
make[5]: *** [install-dist_kde_servicesDATA] Error 1

Rob Savoye <rsavoye>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #14736:  klash_build_fixes2.diff added by mumme (2KiB - text/x-diff - fix a bug in previous patch and add a single switch --with-kde-pluginprefix)
file #14732:  klash_build_fixes.diff added by mumme (2KiB - text/x-diff - auto find kde appsdata dir and add switches for that)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mumme (Updated the item)
  • -unavailable- added by strk
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by rsavoye (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 04 Jan 2008 09:08:20 PM UTCstrkStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Wed 02 Jan 2008 04:47:58 PM UTCmummeAttached File-=>Added klash_build_fixes2.diff, #14736
    Wed 02 Jan 2008 11:33:04 AM UTCmummeAttached File-=>Added klash_build_fixes.diff, #14732
    Sun 30 Dec 2007 10:46:10 AM UTCstrkStatusIn Progress=>Ready For Test
      Carbon-Copy-=>Added bwy
    Sun 30 Dec 2007 10:17:01 AM UTCstrkStatusNone=>In Progress
      Assigned toNone=>strk
    Sun 30 Dec 2007 09:39:57 AM UTCstrkSeverity3 - Normal=>5 - Blocker

    Back to the top


    Powered by Savane 3.1-cleanup1