bugmake - Bugs: bug #21824, Another potential NULL ptr...

 
 

bug #21824: Another potential NULL ptr dereference, on remake.c

Submitted by:  Marcio Buss <marciobuss>
Submitted on:  Tue 18 Dec 2007 03:33:50 AM UTC  
 
Severity: 3 - NormalItem Group: Bug
Status: FixedPrivacy: Public
Assigned to: Paul D. Smith <psmith>Open/Closed: Closed
Component Version: NoneOperating System: None
Fixed Release: 3.82Triage Status: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 02 Aug 2009 11:30:27 PM UTC, comment #1:

Fixed; thanks.

Paul D. Smith <psmith>
Project AdministratorIn charge of this item.
Tue 18 Dec 2007 03:33:50 AM UTC, original submission:

There's a potential null pointer dereference also in remake.c
The error can be tracked down as follows:

(1) Assume the first conjunct is false in the test
"if (file->cmds != 0 && file->cmds->any_recurse)"
This implies that file->cmds is NULL.

(2) item (1) implies that the "if" statement evaluates to
false, and the else branch executes.

(3) we continue the execution till we get to line 861, where
"file->cmds" is dereferenced at statement
"if (! (file->cmds->lines_flags[i-1] & COMMANDS_RECURSE))"

Marcio Buss <marciobuss>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by psmith (Posted a comment)
  • -unavailable- added by marciobuss (Submitted the item)
  • -unavailable- added by marciobuss
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 28 Jul 2010 06:17:32 AM UTCpsmithFixed Release4.0=>3.82
    Sun 02 Aug 2009 11:30:27 PM UTCpsmithAssigned toNone=>psmith
      Open/ClosedOpen=>Closed
      Fixed ReleaseNone=>4.0
      StatusNone=>Fixed
    Tue 18 Dec 2007 03:33:50 AM UTCmarciobussCarbon-Copy-=>Added -unavailable-

    Back to the top


    Powered by Savane 3.1-cleanup1