bugGnash - The GNU Flash player - Bugs: bug #21807, Gnash looks for files in the wrong...

 
 

bug #21807: Gnash looks for files in the wrong place

Submitted by:  Benjamin Wolsey <bwy>
Submitted on:  Sat 15 Dec 2007 12:29:51 PM UTC  
 
Category: pluginSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Sandro Santilli <strk>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sun 16 Dec 2007 10:31:16 AM UTC, comment #8:

Patch committed.

Benjamin Wolsey <bwy>
Project Member
Sat 15 Dec 2007 10:38:42 PM UTC, comment #7:

the important thing is that set_base_url is called before the playback starts (before gui::run).
I think you can commit your patch.
Finding a good place to document supported -P (and thus EMBED/OBJECT attributes) would be nice.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Sat 15 Dec 2007 04:27:25 PM UTC, comment #6:

The problem with that would be that setBaseUrl only changes _baseurl, which is then used in gnash::set_base_url(_baseurl). There is an assert to make sure it's only set once, and that has to happen before the movie is parsed.

The easy answer is to move parsing of FlashVars (and the query string) to before the baseurl is set, which is what the attached patch does.

It fixes that case, just not sure if there might be any issues with changing the order.

(file #14633)

Benjamin Wolsey <bwy>
Project Member
Sat 15 Dec 2007 03:27:26 PM UTC, comment #5:

Please try the attached patch, -U and -P "base=xxx"
both set base URL, whatever comes last overrides the former.
Luckly, plugin.cpp sets -U before -P so should work like it is.

(file #14632)

Sandro Santilli <strk>
Project MemberIn charge of this item.
Sat 15 Dec 2007 02:47:20 PM UTC, comment #4:

or, also maintain the current way (should be passed by -P)
and have -P base=xxx override -U, which should fix this case
w/out touching the plugin code at all.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Sat 15 Dec 2007 01:54:23 PM UTC, comment #3:

Sorry, looking at the EMBED tag it seems 'base' is it.
plugin.cpp should be able to use all EMBED (or OBJECT) attributes,
which currently does by passing them to the standalone using the -P flag.

I guess we'd better not pass base with -P but instead use it to set -U ?

Sandro Santilli <strk>
Project MemberIn charge of this item.
Sat 15 Dec 2007 01:50:08 PM UTC, comment #2:

Maybe we should use the 'src' parameter of the EMBED tag to set base url ? You may try to verify this by copying the HTML locally and see if the proprietary player succeeds in loading the relative urls (making sure baseurl is not specified)

Sandro Santilli <strk>
Project MemberIn charge of this item.
Sat 15 Dec 2007 01:20:17 PM UTC, comment #1:

Plugin gives:

8887] 14:18:25: Setting root URL to http://www.tagesschau.de/static/flash/raf/geschichte.swf
8887] 14:18:25: Setting base URL to http://www.tagesschau.de/multimedia/animation/animation24.html

although it is embedded with:

<EMBED src="http://www.tagesschau.de/static/flash/raf/geschichte.swf" base="http://www.tagesschau.de/static/flash/raf/" menu=false quality=high bgcolor=#00044b WIDTH="540" HEIGHT="370" NAME="Loader" ALIGN="" TYPE="application/x-shockwave-flash" PLUGINSPAGE="http://www.macromedia.com/go/getflashplayer">

Benjamin Wolsey <bwy>
Project Member
Sat 15 Dec 2007 12:29:51 PM UTC, original submission:

The SWF (http://www.tagesschau.de/static/flash/raf/geschichte.swf) on the following page appears not to work: instead of the proper text (loaded from a text file) you get the placeholders ("Headline max 27 z." and "Teaser max 350 z.". The Movieclips don't load either.

http://www.tagesschau.de/multimedia/animation/animation24.html

However, the debug log shows it's looking for all the files in http://www.tagesschau.de/multimedia/animation/, i.e. the base url of the page it's embedded in. In fact, they are in http://www.tagesschau.de/static/flash/raf/, using the base url of the movie. You can verify the movie works (more or less) by running it directly.

From a brief bit of googling it looks like gnash's behaviour is generally correct (and indeed usually works), so I wonder what it's missing in this case.

I haven't verified that the movie works in the pp.

Benjamin Wolsey <bwy>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #14633:  fixbaseurl.patch added by bwy (2KiB - text/x-patch)
file #14632:  baseUrl.diff added by strk (880B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by bwy (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 16 Dec 2007 10:31:16 AM UTCbwyStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Sat 15 Dec 2007 04:27:25 PM UTCbwyAttached File-=>Added fixbaseurl.patch, #14633
    Sat 15 Dec 2007 03:27:26 PM UTCstrkAttached File-=>Added baseUrl.diff, #14632
      CategoryNone=>plugin
      StatusNone=>Ready For Test
      Assigned toNone=>strk

    Back to the top


    Powered by Savane 3.1-cleanup1