bugGnash - The GNU Flash player - Bugs: bug #21567, snopy_click.swf problems.

 
 

bug #21567: snopy_click.swf problems.

Submitted by:  Sandro Santilli <strk>
Submitted on:  Tue 13 Nov 2007 08:49:52 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Sandro Santilli <strk>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Wed 21 Nov 2007 11:21:05 PM UTC, comment #7:

I fixed this by considering a frame_spec evaluating to 0 as a trigger to check labeled frames. No new failures in our testsuite, but snoopy click works.
It seems we'd need some more tests in our testsuite for the specific corner case 0 (a gotoframe.swf in swfdec testsuite seems to be testing for the negative number cases).

Sandro Santilli <strk>
Project MemberIn charge of this item.
Wed 21 Nov 2007 10:56:03 PM UTC, comment #6:

I belive the problem is in sprite_instance::get_frame_number, which relies on a NAN return in order to tell wheter the frame spec was a valid number or not ...

Sandro Santilli <strk>
Project MemberIn charge of this item.
Wed 21 Nov 2007 07:37:44 PM UTC, comment #5:

The change that broke it:

http://cvs.savannah.gnu.org/viewvc/gnash/server/as_value.cpp?root=gnash&r1=1.96&r2=1.97

Sandro Santilli <strk>
Project MemberIn charge of this item.
Wed 21 Nov 2007 07:23:25 PM UTC, comment #4:

Reopening because the cards have stopped appearing.

Running it as a SWF5 or making to_number return NAN in SWF4 (strk) fixes it.

Benjamin Wolsey <bwy>
Project Member
Tue 20 Nov 2007 03:25:39 AM UTC, comment #3:

I believe the whole problem was caused by ActionStringEq, which should respect the swf version.

Zou Lunkai <zoulunkai>
Mon 19 Nov 2007 09:23:41 AM UTC, comment #2:

I think I'v found the culprit after a quick debug. Working on tests at the moment.

Zou Lunkai <zoulunkai>
Tue 13 Nov 2007 08:53:51 AM UTC, comment #1:

News: disabling opcode guard doesn't fix the case.
Also, if you actually find a match gnash goes into an infinite loop !

Sandro Santilli <strk>
Project MemberIn charge of this item.
Tue 13 Nov 2007 08:49:52 AM UTC, original submission:

The attached movie fails with the message:

16010] 09:45:18: DEBUG: Target of action_buffer (_level0.p12 of type gnash::sprite_instance) unloaded by execution of opcode:
PC:368 - EX: ActionCallFrame ()
Discarding 7 bytes of remaining opcodes:
PC:371 - EX: ActionBranchAlways ( 1)
PC:376 - EX: Stop
PC:377 - EX: <End>

After discovering two cards (it's a memo game)

See also bugs: #20974, #21069, #20996

Sandro Santilli <strk>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #14374:  snoopy_click.swf added by strk (212KiB - application/x-shockwave-flash)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bwy (Posted a comment)
  • -unavailable- added by zoulunkai (Posted a comment)
  • -unavailable- added by strk (Submitted the item)
  • -unavailable- added by strk
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 13 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 25 Nov 2007 09:09:32 AM UTCbwyStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Wed 21 Nov 2007 11:21:05 PM UTCstrkStatusIn Progress=>Ready For Test
      Assigned tozoulunkai=>strk
    Wed 21 Nov 2007 07:23:25 PM UTCbwyStatusFixed=>In Progress
      Open/ClosedClosed=>Open
    Tue 20 Nov 2007 06:16:10 AM UTCzoulunkaiStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Tue 20 Nov 2007 03:25:39 AM UTCzoulunkaiStatusNone=>In Progress
      Assigned toNone=>zoulunkai
    Tue 13 Nov 2007 08:53:51 AM UTCstrkSummarysnopy_click.swf fails due to opcode guard=>snopy_click.swf problems.
    Tue 13 Nov 2007 08:49:52 AM UTCstrkAttached File-=>Added snoopy_click.swf, #14374
      Carbon-Copy-=>Added zoulunkai

    Back to the top


    Powered by Savane 3.1-cleanup1