bugPSPP - Bugs: bug #21516, libxml2 isn't optional

 
 

bug #21516: libxml2 isn't optional

Submitted by:  Jason H Stover <jstover>
Submitted on:  Mon 05 Nov 2007 05:01:58 PM UTC  
 
Category: NoneSeverity: 5 - Average
Status: NoneAssigned to: None
Open/Closed: ClosedRelease: Before 0.6.0
Effort: 0.00

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Tue 06 Nov 2007 02:46:34 PM UTC, comment #7:

John's checkin and the #include fixed the problem.
I'll close this.

Jason H Stover <jstover>
Project Member
Tue 06 Nov 2007 06:26:16 AM UTC, comment #6:

>Probably just needs #include <sys/stat.h> at the top.


This was obviously needed, so I checked it in without verifying that it fixed the problem.

Ben Pfaff <blp>
Project Administrator
Tue 06 Nov 2007 04:13:17 AM UTC, comment #5:

>this time in src/data/make-file.c. struct stat confuses the
>compiler:


Probably just needs #include <sys/stat.h> at the top. Can you try that?

>...it looks like I should have tested this one while it was still
>just a patch, too.


No worries. Stuff breaks once in a while. We just fix it.

Ben Pfaff <blp>
Project Administrator
Tue 06 Nov 2007 03:55:03 AM UTC, comment #4:

This seemed to work, but now the compilation is breaking because of another problem, this time in src/data/make-file.c. struct stat confuses the compiler:

$ gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I./gl -I./gl -I./src/language/stats -I./src/language/expressions -I./sr
c/language/expressions -I./src -I./lib -DPKGDATADIR=\"/usr/local/share/pspp\" -I/usr/local/include -Wall -W -Wwr
ite-strings -Wstrict-prototypes -Wpointer-arith -Wno-sign-compare -Wmissing-prototypes -g -O2 -MT src/data/src_d
ata_libdata_a-make-file.o -MD -MP -MF src/data/.deps/src_data_libdata_a-make-file.Tpo -c -o src/data/src_data_lib
data_a-make-file.o `test -f 'src/data/make-file.c' || echo './'`src/data/make-file.c
src/data/make-file.c: In function `replace_file_start':
src/data/make-file.c:131: error: storage size of `s' isn't known

...it looks like I should have tested this one while it was still just a patch, too.

Jason H Stover <jstover>
Project Member
Mon 05 Nov 2007 10:01:09 PM UTC, comment #3:

$ grep GNM_SUPPORT config.h
#define GNM_SUPPORT 1

Jason H Stover <jstover>
Project Member
Mon 05 Nov 2007 09:51:05 PM UTC, comment #2:

What's the value of GNM_SUPPORT in your config.h file?

John Darrington <jmd>
Project Administrator
Mon 05 Nov 2007 07:39:48 PM UTC, comment #1:

In the summary, I meant to say libxml2 isn't optional, not that the gnumeric code itself isn't optional.

Jason H Stover <jstover>
Project Member
Mon 05 Nov 2007 05:01:58 PM UTC, original submission:

I'm sorry I didn't check this on OBSD before John checked it
in, but I figured it wouldn't matter on that OS. (I'm not sure why I thought that). The INSTALL file states libxml2 is optional, so is it possible to make ./configure --without-libxml2 didn't seem to help.

$ make
...
...
gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I./gl -I./gl -I./src/language/stats -I./src/language/expressions -I./src/language/expressions -I./src -I./lib -DPKGDATADIR=\"/usr/local/share/pspp\" -I/usr/local/include -Wall -W -Wwrite-strings -Wstrict-prototypes -Wpointer-arith -Wno-sign-compare -Wmissing-prototypes -g -O2 -MT src/data/src_data_libdata_a-gnumeric-reader.o -MD -MP -MF src/data/.deps/src_data_libdata_a-gnumeric-reader.Tpo -c -o src/data/src_data_libdata_a-gnumeric-reader.o `test -f 'src/data/gnumeric-reader.c' || echo './'`src/data/gnumeric-reader.c
src/data/gnumeric-reader.c:49:30: libxml/xmlreader.h: No such file or directory

Jason H Stover <jstover>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by blp (Posted a comment)
  • -unavailable- added by jmd (Posted a comment)
  • -unavailable- added by jstover (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 06 Nov 2007 02:47:12 PM UTCjstoverOpen/ClosedOpen=>Closed
    Tue 06 Nov 2007 11:25:52 AM UTCjmdReleaseNone=>Before 0.6.0
    Mon 05 Nov 2007 07:39:48 PM UTCjstoverSummarygnumeric-reader.c isn\'t optional=>libxml2 isn't optional

    Back to the top


    Powered by Savane 3.1-cleanup1