bugPSPP - Bugs: bug #21397, read error in filter command

 
 

bug #21397: read error in filter command

Submitted by:  John Darrington <jmd>
Submitted on:  Tue 23 Oct 2007 01:18:33 PM UTC  
 
Category: OtherSeverity: 7 - Major
Status: FixedAssigned to: None
Open/Closed: ClosedRelease: Before 0.6.0
Effort: 0.00

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 27 Oct 2007 07:12:52 AM UTC, comment #4:

Thanks Jason. I'm committing this, and closing both items.

John Darrington <jmd>
Project Administrator
Fri 26 Oct 2007 02:02:25 PM UTC, comment #3:

Works on OBSD, and it seems to have fixed bug 21330.

Jason H Stover <jstover>
Project Member
Fri 26 Oct 2007 10:50:28 AM UTC, comment #2:

I think the attached patch should fix the problem.

(file #14217)

John Darrington <jmd>
Project Administrator
Thu 25 Oct 2007 08:45:25 AM UTC, comment #1:

The attached file seems to trigger this problem and crash. I strongly suspect this is also the cause of #21330

(file #14203)

John Darrington <jmd>
Project Administrator
Tue 23 Oct 2007 01:18:33 PM UTC, original submission:

Valgrind shows the following error when running tests/command/filter.sh

==13206== Invalid read of size 4
==13206== at 0x80F5B5F: dict_var_changed (dictionary.c:1168)
==13206== by 0x81088DD: var_set_leave (variable.c:784)
==13206== by 0x8053080: lvalue_finalize (compute.c:408)
==13206== by 0x80526F1: cmd_compute (compute.c:101)
==13206== by 0x804F2DD: do_parse_command (command.c:235)
==13206== by 0x804F02E: cmd_parse_in_state (command.c:148)
==13206== by 0x804F112: cmd_parse (command.c:165)
==13206== by 0x804D83A: main (main.c:124)
==13206== Address 0x4755958 is 64 bytes inside a block of size 72 free'd
==13206== at 0x4023FA5: free (vg_replace_malloc.c:233)
==13206== by 0x80F3A0D: dict_destroy (dictionary.c:230)
==13206== by 0x80FB33C: proc_cancel_temporary_transformations (procedure.c:490)
==13206== by 0x80FAEB1: proc_commit (procedure.c:313)
==13206== by 0x80A10C6: cmd_list (list.q:250)
==13206== by 0x804F2DD: do_parse_command (command.c:235)
==13206== by 0x804F02E: cmd_parse_in_state (command.c:148)
==13206== by 0x804F112: cmd_parse (command.c:165)
==13206== by 0x804D83A: main (main.c:124)
==13206==

John Darrington <jmd>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #14217:  vardict-bug.patch added by jmd (3KiB - text/x-diff)
file #14203:  crash.sps added by jmd (185B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jstover (Posted a comment)
  • -unavailable- added by jmd (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 27 Oct 2007 07:12:52 AM UTCjmdStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Fri 26 Oct 2007 10:50:28 AM UTCjmdAttached File-=>Added vardict-bug.patch, #14217
    Thu 25 Oct 2007 08:45:25 AM UTCjmdAttached File-=>Added crash.sps, #14203
      CategoryNone=>Other
      Severity5 - Average=>7 - Major
      ReleaseNone=>Before 0.6.0

    Back to the top


    Powered by Savane 3.1-cleanup1