bugGnash - The GNU Flash player - Bugs: bug #21272, Key releases handled incorrectly

 
 

bug #21272: Key releases handled incorrectly

Submitted by:  Benjamin Wolsey <bwy>
Submitted on:  Sat 06 Oct 2007 03:38:39 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 08 Oct 2007 01:07:02 PM UTC, comment #1:

I've made that change, which fixes the release event handling. As far as I can tell, it shouldn't (and doesn't) break anything else (testsuite is fine), but if anyone spots strange effects on key presses, it may well be down to this.

Benjamin Wolsey <bwy>
Project Member
Sat 06 Oct 2007 03:38:39 PM UTC, original submission:

When you press several keys at once and release any key, the key supposedly released is always the last key pressed.

This is because:

server/asobj/Key.cpp, key_get_code (line 256)

uses m_last_key_pressed. This is only changed (as the name suggests) when a key is pressed in set_key_down(int code) (line 76), but not when released.

The question is: does anything rely on knowing the last key pressed as opposed to the last key event? If not, I would add

m_last_key_pressed = code;

to set_key_up as well, which would solve some, but not all current problems with key presses. It might get a name change too.

keyevent.swf is useful for testing.

Benjamin Wolsey <bwy>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #14102:  keyevent.swf added by bwy (526B - application/x-shockwave-flash)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bwy (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 08 Oct 2007 01:07:02 PM UTCbwyStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Sat 06 Oct 2007 03:38:40 PM UTCbwyAttached File-=>Added keyevent.swf, #14102

    Back to the top


    Powered by Savane 3.1-cleanup1