bugGnash - The GNU Flash player - Bugs: bug #21177, Noisy ADPCM sound playing feed.swf

 
 

bug #21177: Noisy ADPCM sound playing feed.swf

Submitted by:  Sandro Santilli <strk>
Submitted on:  Fri 28 Sep 2007 07:25:59 AM UTC  
 
Category: soundSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Bastiaan Jacques <bjacques>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Tue 22 Feb 2011 02:19:30 PM UTC, comment #20:

Great! Works fine.

Benjamin Wolsey <bwy>
Project Member
Tue 22 Feb 2011 02:01:16 PM UTC, comment #19:

I did succeed in reproducing the but in FFMPEG, which should now be fixed in master.

It turns out AudioDecoderSimple doesn't make for a very good ADPCM decoder, so now AudioDecoderGst is able to hande it as well. (Gst-ffmpeg required, though.)

Bastiaan Jacques <bjacques>
Project MemberIn charge of this item.
Mon 21 Feb 2011 02:47:37 PM UTC, comment #18:

Blocker filed as another bug #32557 so this is for the noisy sound only.

Benjamin Wolsey <bwy>
Project Member
Mon 21 Feb 2011 01:13:54 PM UTC, comment #17:

I get noise with ffmpeg, okay with GST, but more concerningly trunk blocks at:

#0 __lll_lock_wait ()
at ../nptl/sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:136
#1 0x00007ffff79720e9 in _L_lock_953 () from /lib/libpthread.so.0
#2 0x00007ffff7971f0b in __pthread_mutex_lock (mutex=0x6b7b20)
at pthread_mutex_lock.c:61
#3 0x00007ffff69cd5a3 in boost::mutex::lock (this=0x7fffffffb480, m_=...)
at /usr/include/boost/thread/pthread/mutex.hpp:50
#4 boost::unique_lock<boost::mutex>::lock (this=0x7fffffffb480, m_=...)
at /usr/include/boost/thread/locks.hpp:349
#5 unique_lock (this=0x7fffffffb480, m_=...)
at /usr/include/boost/thread/locks.hpp:227
#6 0x00007ffff69cbf98 in gnash::sound::SDL_sound_handler::unplugInputStream (
this=0x6b7a80, id=0x876d60)
at /home/benjamin/Downloads/gnash/trunk/libsound/sdl/sound_handler_sdl.cpp:344
#7 0x00007ffff69bc018 in gnash::sound::sound_handler::stopEmbedSoundInstances
(this=0x6b7a80, def=...)
at /home/benjamin/Downloads/gnash/trunk/libsound/sound_handler.cpp:234
#8 0x00007ffff69bc088 in gnash::sound::sound_handler::stop_all_sounds (
this=0x6b7a80)
at /home/benjamin/Downloads/gnash/trunk/libsound/sound_handler.cpp:143
#9 0x00007ffff69cc138 in gnash::sound::SDL_sound_handler::stop_all_sounds (
this=0x6b7a80)

with both gst and ffmpeg.

Benjamin Wolsey <bwy>
Project Member
Sun 20 Feb 2011 08:57:38 PM UTC, comment #16:

Works fine with both Gstreamer and Ffmpeg for me (although ADPCM is played with AudioDecoderSimple, apparently).

Bastiaan Jacques <bjacques>
Project MemberIn charge of this item.
Tue 04 Jan 2011 01:16:53 AM UTC, comment #15:

With gst, it's perfect.
With ffmpeg, it can't play well some sounds. Noisy? Yes noisy.

17469:1] 02:14:33 DEBUG: AudioDecoderFfmpeg: initialized FFmpeg codec 69645 (adpcm_swf) for flash codec 1 (ADPCM)

Gabriele Giacone <gg0>
Project Member
 Spam posted by susancai
 Spam posted by an anonymous
 Spam posted by vivamauer
Tue 02 Dec 2008 11:48:08 AM UTC, comment #14:

It's still noisy. The file is attached.

Benjamin Wolsey <bwy>
Project Member
Fri 28 Nov 2008 12:16:39 PM UTC, comment #13:

If you attach it I give it a try.

Sandro Santilli <strk>
Project Member
Fri 28 Nov 2008 12:15:19 PM UTC, comment #12:

Hi!

Yep! A guy is sitting on a bench feeding a bird weird stuff, and also hitting it with a racket :)

Tomas Groth <tgc>
Fri 28 Nov 2008 09:54:14 AM UTC, comment #11:

I've lost feed.swf with my hard-disk. so can't test atm.
Was a guy feeding birds...

Sandro Santilli <strk>
Project Member
Fri 28 Nov 2008 09:40:12 AM UTC, comment #10:

Still a bug?

Benjamin Wolsey <bwy>
Project Member
Thu 24 Jan 2008 11:18:14 AM UTC, comment #9:

feed.swf still plays noise.
It's likely parser related more then media-handler, as ffmpeg
had the same problem.

Sandro Santilli <strk>
Project Member
Thu 04 Oct 2007 12:26:32 PM UTC, comment #8:

much closer to 0.8.1 as far as I can tell.
only tested those 2 ones.
I guess we can close this one if we have another bug for ADPCM parsing/decoding (and if you confirm these two tests are ADPCM related)

Sandro Santilli <strk>
Project Member
Thu 04 Oct 2007 11:27:30 AM UTC, comment #7:

I committed a new patch which improves adpcm decoding even more. Please test with your various files.

Tomas Groth <tgc>
Thu 04 Oct 2007 09:06:10 AM UTC, comment #6:

Magical trevor worked before too.
I still have the noise for both feed.swf and 568db6323c3109f.swf

I tried with 0.8.1 and yes I can still ear some noise with feed.swf, but less, and much less noise with 568db6323c3109f.swf

Sandro Santilli <strk>
Project Member
Thu 04 Oct 2007 06:45:20 AM UTC, comment #5:

Magical Trevor works for me again after that patch.

Benjamin Wolsey <bwy>
Project Member
Wed 03 Oct 2007 09:44:43 PM UTC, comment #4:

I committed a patch that I think will solve some of these noise issues. Feel free to test.

Tomas Groth <tgc>
Fri 28 Sep 2007 03:10:44 PM UTC, comment #3:

I confirm sound is fine with 0.8.1 and not with head.
BitsReader will loop around the buffer when trying to read beyond (tgc asked in irc).

Sandro Santilli <strk>
Project Member
Fri 28 Sep 2007 10:52:42 AM UTC, comment #2:

I've changed back to using our internal ADPCM decoder, but i don't think it's improving...
Btw, i didn't get more noise with ffmpeg-libmedia than before, maybe ffmpeg has had a recent improvement.

Tomas Groth <tgc>
Fri 28 Sep 2007 07:28:35 AM UTC, comment #1:

Similar issue with this:
56104186a2ec8a614e0bfb4aad4e9423 swf4/feed.swf

Magical trevor seems fine:
ea8bbad50ccbc52dd734dfc93a7f06a7 swf5/6964trev3c.swf

Sandro Santilli <strk>
Project Member
Fri 28 Sep 2007 07:25:59 AM UTC, original submission:

The testfile:

0ecb986f13a8d5bbc50769dc566d7c86 swf3/568db6323c3109f.swf

I'm pretty sure it used to work before libmedia.

Sandro Santilli <strk>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #16965:  feed.swf added by bwy (267KiB - application/x-shockwave-flash)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bjacques (Posted a comment)
  • -unavailable- added by gg0 (Posted a comment)
  • -unavailable- added by susancai (Posted a comment)
  • -unavailable- added by vivamauer (Posted a comment)
  • -unavailable- added by bwy (Posted a comment)
  • -unavailable- added by tgc (Posted a comment)
  • -unavailable- added by strk (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 11 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 22 Feb 2011 02:19:30 PM UTCbwyStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Tue 22 Feb 2011 02:01:16 PM UTCbjacquesCategorysound-gst=>sound
      StatusNone=>Ready For Test
      Assigned toNone=>bjacques
    Tue 02 Dec 2008 11:44:28 AM UTCbwyAttached File-=>Added feed.swf, #16965
    Thu 24 Jan 2008 11:18:14 AM UTCstrkCategorysound-sdl=>sound-gst
      StatusIn Progress=>None
      Assigned totgc=>None
      SummaryNoise from ffmpeg since libmedia introduction=>Noisy ADPCM sound playing feed.swf
    Fri 28 Sep 2007 10:52:42 AM UTCtgcStatusNone=>In Progress

    Back to the top


    Powered by Savane 3.1-cleanup1