bugGnash - The GNU Flash player - Bugs: bug #21168, Zoomhenge zooms out to NaN

 
 

bug #21168: Zoomhenge zooms out to NaN

Submitted by:  Benjamin Wolsey <bwy>
Submitted on:  Thu 27 Sep 2007 07:06:18 AM UTC  
 
Category: ActionScriptSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Sandro Santilli <strk>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sat 06 Oct 2007 12:19:31 PM UTC, comment #9:

Closing...

Benjamin Wolsey <bwy>
Project Member
Sat 06 Oct 2007 08:14:01 AM UTC, comment #8:

You should make a test like:

as_value v("0.5");
check_equals(v.to_number(), 0);

best place would be testsuite/server/AsValueTest.cpp (to be created).

You'll need to setup some environment. Check testsuite/server/PropertyListTest.cpp for an example setup
(note the fake VM)

Sandro Santilli <strk>
Project MemberIn charge of this item.
Sat 06 Oct 2007 07:31:46 AM UTC, comment #7:

Having pored over the verbose output from zoomhenge, it looks like my problem arises in ActionToNumber, which converts

"[string:zoom]" | "[string:0.5]"

to

"[string:zoom]" | "[number:nan]"

In all the other instances it successfully converts string to number. Extracts from -va output attached that show the process for zooming from 2.5 to 3 (correct conversion of string to number) and 0.5 (incorrect). Not sure why this should affect me and not anyone else.

(file #14100)

Benjamin Wolsey <bwy>
Project Member
Sat 06 Oct 2007 06:55:27 AM UTC, comment #6:

No, still the same problem.

Benjamin Wolsey <bwy>
Project Member
Sat 06 Oct 2007 06:31:22 AM UTC, comment #5:

Does this work for you after fixing the key release thing ?

Sandro Santilli <strk>
Project MemberIn charge of this item.
Thu 04 Oct 2007 11:47:46 AM UTC, comment #4:

The ming part of the testsuite has never worked properly for me; many of the test runners give segfaults, and now even while building the tests.

The notable thing about the key events is that arrow key releases are not registered. But this surely can't have anything to do with the mouse click zooming by a different amount (unless that is supposed to happen).

Benjamin Wolsey <bwy>
Project Member
Thu 04 Oct 2007 10:20:00 AM UTC, comment #3:

md5: 00cb6537c4a07b551437737e43bba4de

we're both using the same SWF, works for me and not for you.
I'd look at key events as first thing.
But could also be something related to differences in floating point numbers. Does 'make check' succeed for you ?

Sandro Santilli <strk>
Project MemberIn charge of this item.
Thu 04 Oct 2007 09:28:36 AM UTC, comment #2:

Hasn't made any difference for me. Attaching zoomhenge in case we have different versions. Zooming in with the keyboard has increments of one, with the mouse of 0.5. It zooms out too far whichever I use to zoom in, though.

(file #14077)

Benjamin Wolsey <bwy>
Project Member
Thu 04 Oct 2007 09:13:59 AM UTC, comment #1:

I can't reproduce.
Maybe was fixed by the fixes in ActionShiftRight, can you check ?

Sandro Santilli <strk>
Project MemberIn charge of this item.
Thu 27 Sep 2007 07:06:18 AM UTC, original submission:

Press the down arrow to zoom out. It should stop at 2x, but goes to 1x, then 0.5x, then NaN and stops responding to the mouse.

There looks like an error zooming in, which goes in steps of 0.5 while zooming out has steps of 1. Once you reach 0.5x, the next step is always NaN (zoom in or out).

Benjamin Wolsey <bwy>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #14100:  zoomhenge.log added by bwy (5KiB - text/x-log)
file #14077:  zoomhenge.swf added by bwy (232KiB - application/x-shockwave-flash)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by bwy (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 06 Oct 2007 12:20:10 PM UTCbwyOpen/ClosedOpen=>Closed
    Sat 06 Oct 2007 12:19:31 PM UTCbwyStatusReady For Test=>Fixed
    Sat 06 Oct 2007 07:31:46 AM UTCbwyAttached File-=>Added zoomhenge.log, #14100
    Thu 04 Oct 2007 09:28:36 AM UTCbwyAttached File-=>Added zoomhenge.swf, #14077
    Thu 04 Oct 2007 09:13:59 AM UTCstrkStatusNone=>Ready For Test
      Assigned toNone=>strk

    Back to the top


    Powered by Savane 3.1-cleanup1