bugGnash - The GNU Flash player - Bugs: bug #21130, Youtube videos skip straight to...

 
 

bug #21130: Youtube videos skip straight to the end

Submitted by:  Chad Musick <cmusick>
Submitted on:  Thu 20 Sep 2007 01:44:34 PM UTC  
 
Category: videoSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Sandro Santilli <strk>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sat 22 Sep 2007 09:48:37 PM UTC, comment #6:

I reverted that change, to fix youtube. Still working on execution order though...

Sandro Santilli <strk>
Project MemberIn charge of this item.
Sat 22 Sep 2007 08:09:25 AM UTC, comment #5:

swfdec test case is made with Ming, and has source code.
It basically tests that registerClass doesn't have any effect
on instances created before that call.
Now I guess we're calling registerClass too early then, as the CONSTRUCT event is queued so use of registerClass is used after init actions for that frame have been executed.
Talking about my patch of course.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Sat 22 Sep 2007 07:53:27 AM UTC, comment #4:

It seems executing the construction phase after init actions (queuing it) isn't enogh for youtube to work. It doesn't skip
straight to the end but video doesn't start :(

My patch basically queues a CONSTRUCT event from stagePlacementCallback and have on_event() call a new constructAsObject private method if the event_id is CONSTRUCT...

Interestingly, there's an swfdec testcase called registerclass-previous.swf which is also failing with this layout

Sandro Santilli <strk>
Project MemberIn charge of this item.
Thu 20 Sep 2007 07:38:22 PM UTC, comment #3:

Found the culprit: execution of init actions.
Executing init actions after DLIST tags breaks youtube in this
way, executing them before breaks our testcases.

I guess this is related to onConstruct events, which are known
to be bogus. Seems time to fix them too.

Zou: time for more testcases about onConstruct/onLoad/onInitialize
and I'll try my cascading events design probably.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Thu 20 Sep 2007 05:01:44 PM UTC, comment #2:

2007-09-19 # fails
2007-08-18 # succeeds

All changes in between are mine..

Sandro Santilli <strk>
Project MemberIn charge of this item.
Thu 20 Sep 2007 04:18:30 PM UTC, comment #1:

cvs update -D 2007-09-18 # works fine

Sandro Santilli <strk>
Project MemberIn charge of this item.
Thu 20 Sep 2007 01:44:34 PM UTC, original submission:

Youtube videos are not playable any more -- they skip straight to the end of the video, where they flash the 'play again' and 'share' buttons.

Chad Musick <cmusick>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by butdiene
  • -unavailable- added by strk
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by cmusick (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 22 Sep 2007 09:48:37 PM UTCstrkStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Sat 22 Sep 2007 07:53:27 AM UTCstrkStatusConfirmed=>In Progress
    Fri 21 Sep 2007 05:43:27 AM UTCbutdieneCarbon-Copy-=>Added butdiene
    Thu 20 Sep 2007 07:38:23 PM UTCstrkCarbon-Copy-=>Added zoulunkai
    Thu 20 Sep 2007 04:18:30 PM UTCstrkStatusNone=>Confirmed
      Assigned toNone=>strk

    Back to the top


    Powered by Savane 3.1-cleanup1