bugGnash - The GNU Flash player - Bugs: bug #21126, race condition playing...

 
 

bug #21126: race condition playing gotoframe.swf from swfdec testsuite

Submitted by:  Sandro Santilli <strk>
Submitted on:  Wed 19 Sep 2007 08:54:36 PM UTC  
 
Category: coreSeverity: 4 - Important
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Sandro Santilli <strk>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Fri 21 Sep 2007 01:16:23 AM UTC, comment #7:

m_current_frame is used for builtin "_currentframe" property, right?

_currentframe need to be set in this case(I am sure of this).

I reviewed your last commit, it make sense to me, should be fine now.

Zou Lunkai <zoulunkai>
Thu 20 Sep 2007 11:07:28 AM UTC, comment #6:

Can you explain to me why is setting m_current_frame needed ?

Sandro Santilli <strk>
Project MemberIn charge of this item.
Thu 20 Sep 2007 10:26:00 AM UTC, comment #5:

Without this revert, there is a infinite loop with get_frame_number_test.swf, also blocks our 'make check'.

I'll check swfdec/test/trace/gotoframe.swf tomorrow to see if any other solution.

Zou Lunkai <zoulunkai>
Thu 20 Sep 2007 10:06:42 AM UTC, comment #4:

Reopening this, since zou reverted the change which fixed it..

Sandro Santilli <strk>
Project MemberIn charge of this item.
Wed 19 Sep 2007 11:30:07 PM UTC, comment #3:

sprite_instance::goto_frame was failing to wait for target frame to be loaded, so we used to jump to frame 15 w/out having loaded it, and more interestingly w/out having loaded frame 14, which was labeled as 12d, being the target of the gotoFrame executed next...

I committed a patch fixing the missing "wait" for target frame, still it would be interesting to check what happens if a gotoFrame (yet-to-be-parsed-label) is issued.

Zou: this bug was introduced by your commit:

http://cvs.savannah.gnu.org/viewvc/gnash/server/sprite_instance.cpp?root=gnash&r1=1.227&r2=1.228

Sandro Santilli <strk>
Project MemberIn charge of this item.
Wed 19 Sep 2007 10:00:49 PM UTC, comment #2:

Also, you need to overload your CPU in order to detect that race condition. I use to build gnash in another tree while running the swfdec_gnash_tester in a loop...

Sandro Santilli <strk>
Project MemberIn charge of this item.
Wed 19 Sep 2007 09:30:07 PM UTC, comment #1:

Disabling threading fixes this

Sandro Santilli <strk>
Project MemberIn charge of this item.
Wed 19 Sep 2007 08:54:36 PM UTC, original submission:

I've noticed that the gotoframe.swf testcase from swfdec testsuite triggers a race condition in Gnash.

You can run:
./swfdec_gnash_tester .../swfdec/test/trace/gotoframe.swf

No output means the test succeeded, a diff output shows differences
between expected and obtained results.

Running the above multiple times results in failures or successes
intermittently.

Sandro Santilli <strk>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by zoulunkai (Posted a comment)
  • -unavailable- added by strk
  • -unavailable- added by strk (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 21 Sep 2007 05:20:10 AM UTCstrkOpen/ClosedOpen=>Closed
    Thu 20 Sep 2007 10:06:42 AM UTCstrkOpen/ClosedClosed=>Open
    Wed 19 Sep 2007 11:30:07 PM UTCstrkStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Wed 19 Sep 2007 08:54:36 PM UTCstrkCarbon-Copy-=>Added zoulunkai

    Back to the top


    Powered by Savane 3.1-cleanup1