bugPSPP - Bugs: bug #21101, crashes when plotting histogram...

 
 

bug #21101: crashes when plotting histogram with normal curve

Submitted by:  John Darrington <jmd>
Submitted on:  Mon 17 Sep 2007 01:32:29 PM UTC  
 
Category: Output DriverSeverity: 5 - Average
Status: FixedAssigned to: None
Open/Closed: ClosedRelease: None
Effort: 0.00

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 19 Sep 2007 01:58:15 AM UTC, comment #3:

I checked this in, thanks for review.

Ben Pfaff <blp>
Project Administrator
Tue 18 Sep 2007 11:56:53 AM UTC, comment #2:

You're right of course. Check it in at your convenience.

John Darrington <jmd>
Project Administrator
Tue 18 Sep 2007 04:42:10 AM UTC, comment #1:

>This syntax causes an assertion failure.


The assertion failure on this line:
assert(range == x_max - not_used);
where range, x_max, and not_used are all "double"s. Thus, this assertion is simply invalid, because it assumes that "double"s are infinitely precise. You can see from my GDB session below that in fact the value of range is quite close to x_max - not_used:

(gdb) p range
$1 = 3.4545454545454533
(gdb) p x_max
$2 = 3
(gdb) p not_used
$3 = -0.45454545454545453

Thus, I'm attaching a patch that simply removes the assertion.

(file #13977)

Ben Pfaff <blp>
Project Administrator
Mon 17 Sep 2007 01:32:29 PM UTC, original submission:

This syntax causes an assertion failure.

DATA LIST LIST /x.
BEGIN DATA.
-4.7
-34
2.4
-2.5
-4.5
-3.0
END DATA

frequencies x
/histogram = normal.

John Darrington <jmd>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by blp (Updated the item)
  • -unavailable- added by jmd (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 19 Sep 2007 01:58:15 AM UTCblpStatusReady for Test/Review=>Fixed
      Open/ClosedOpen=>Closed
    Tue 18 Sep 2007 04:42:10 AM UTCblpAttached File-=>Added histogram_plot-assertion-fix.patch, #13977
      CategoryNone=>Output Driver
      StatusNone=>Ready for Test/Review

    Back to the top


    Powered by Savane 3.1-cleanup1