bugGnash - The GNU Flash player - Bugs: bug #21094, DelaySeek field for MP3 in...

 
 

bug #21094: DelaySeek field for MP3 in DEFINESOUND is not parsed

Submitted by:  None
Submitted on:  Sun 16 Sep 2007 08:46:19 AM UTC  
 
Category: parserSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Tomas Groth <tgc>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 17 Sep 2007 12:34:23 PM UTC, comment #3:

Thanks for the patch, it is now committed!
The delay value isn't used yet, but if you feel like looking more into it, feel free to do it :)

Tomas Groth <tgc>In charge of this item.
Sun 16 Sep 2007 10:13:33 AM UTC, comment #2:

Thank you Lauri.
Thomas, will you look at this ?

Sandro Santilli <strk>
Project Member
Sun 16 Sep 2007 08:52:01 AM UTC, comment #1:

Sorry for anonymous submission, I didn't notice that I wasn't logged in.

Lauri Mylläri <rez>
Sun 16 Sep 2007 08:46:19 AM UTC, original submission:

Both 0.8.1 and current CVS have a problem with MP3 in DEFINESOUND tag. This shows up as libavcodec errors and missing sound in case of short sounds. (I am using ffmpeg, agg and GTK. I think this also affects GStreamer handler.)

Try for example http://games.funnygames.nl/bubbels.swf - when you launch a bubble and it hits another bubble, a sound should play. Instead the following is logged:

mdb:78, lastbuf:0 skipping granule 0

Dumping raw mp3 data from SDL_sound_handler and comparing with swfextract output I noticed that there are two extra bytes before MP3 frame header.

These bytes are apparently the DelaySeek field. See http://www-lehre.informatik.uni-osnabrueck.de/~fbstark/diplom/docs/swf/Sounds.htm for an explanation.

The attached patch reads the DelaySeek field, so create_sound() is passed the right amount of data starting at the MP3 frame header. The value is not stored or handled in any way yet, as I do not know enough about SWF to implement it. If anyone has any nice testcases where DelaySeek makes a notable difference, I'm willing to try though. It doesn't look too difficult.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #13957:  gnash_read_mp3_delayseek.patch added by None (1KiB - text/x-patch - read DelaySeek field from DEFINESOUND)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by tgc (Posted a comment)
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by rez (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 17 Sep 2007 12:34:23 PM UTCtgcStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Sun 16 Sep 2007 10:13:33 AM UTCstrkAssigned toNone=>tgc
    Sun 16 Sep 2007 08:46:19 AM UTCNoneAttached File-=>Added gnash_read_mp3_delayseek.patch, #13957

    Back to the top


    Powered by Savane 3.1-cleanup1