bugGnash - The GNU Flash player - Bugs: bug #20866, Performance problems playing...

 
 

bug #20866: Performance problems playing Ninjai movies

Submitted by:  Udo Giacomozzi <udog>
Submitted on:  Wed 22 Aug 2007 10:03:16 AM UTC  
 
Category: soundSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Tomas Groth <tgc>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Thu 04 Oct 2007 09:09:06 AM UTC, comment #18:

Please use bug #19832 for audio/video sync problem.

Sandro Santilli <strk>
Project Member
Thu 04 Oct 2007 09:03:46 AM UTC, comment #17:

I also confirm that the sound problems vanished (except for out-of-sync) and loading is quite fast now.

Good job :)

Udo Giacomozzi <udog>
Project Member
Thu 04 Oct 2007 07:58:39 AM UTC, comment #16:

I confirm loading is really fast now with both FFMPEG and GST.

Sandro Santilli <strk>
Project Member
Wed 03 Oct 2007 09:46:23 PM UTC, comment #15:

I guess this is fixed now?

Tomas Groth <tgc>In charge of this item.
Wed 26 Sep 2007 09:45:02 AM UTC, comment #14:

I'm giving up in cleaning up the SDL sound handler.
The current design is too confusing. active_sound ownership is not documented, and they are actually never deleted, "raw" data is sometimes a newly allocated memory and sometimes a pointer to the "undecoded data".

I'll leave this to TGC.
For now, GST sound handler does an acceptable work.

Sandro Santilli <strk>
Project Member
Tue 25 Sep 2007 08:24:44 PM UTC, comment #13:

sound_data buffer reallocation was too aggressive.
I fixed it for gst, will fix for ffmpeg too.
Please have a try now.

Sandro Santilli <strk>
Project Member
Tue 25 Sep 2007 06:06:56 PM UTC, comment #12:

The culprit is here:

long start = handler->fill_stream_data(data, data_bytes, sample_count, handle_id);

This is from sound_stream_block_loader.
BTW, the memory copy is also useless, the data passed to that function is immediately released after the copy, might as well be just transferred as ownership instead.

PS: I changed the bug summary since the sound problem was fixed.

Sandro Santilli <strk>
Project Member
Tue 25 Sep 2007 05:02:41 PM UTC, comment #11:

I just tried with gst, same speedup experienced.
Must be parsing of sound tag then ?

Sandro Santilli <strk>
Project Member
Tue 25 Sep 2007 04:27:15 PM UTC, comment #10:

yes, this is with ffmpeg, haven't tested gst. I'm a bit surprised by the speed-up since we don't do decoding when parsing (except for adpcm), we only copy buffers.

Tomas Groth <tgc>In charge of this item.
Tue 25 Sep 2007 04:24:32 PM UTC, comment #9:

Are you using ffmpeg as well ?

Sandro Santilli <strk>
Project Member
Tue 25 Sep 2007 04:23:15 PM UTC, comment #8:

I also see the speed-up with no soundhandler. I guess there should be a speed-up, but it seems a bit extreme in this case.

Tomas Groth <tgc>In charge of this item.
Tue 25 Sep 2007 04:08:08 PM UTC, comment #7:

btw, wiki page url changed to:
http://wiki.gnashdev.org/wiki/index.php/NinjaProfile

Sandro Santilli <strk>
Project Member
Tue 25 Sep 2007 04:07:28 PM UTC, comment #6:

About the performance problem... it seems that running with -r1 (disables sound) loads pretty quick. Can you confirm ?

Sandro Santilli <strk>
Project Member
Fri 24 Aug 2007 05:07:04 PM UTC, comment #5:

(O/T): http://www.gnashdev.org/wiki/index.php/NinjaProfile

Sandro Santilli <strk>
Project Member
Fri 24 Aug 2007 02:41:13 PM UTC, comment #4:

(O/T) yes, it's frustating, it takes an eternity. Maybe the input stream class (which can read bitwise) is too slow?

But better discuss this in another place..

Udo Giacomozzi <udog>
Project Member
Thu 23 Aug 2007 05:08:45 PM UTC, comment #3:

Tomas added code to try syncing audio to video in HEAD (GST).
There's a bug open for it. He reverted the change in 0.8.1 branch, should
do in head too...
See bug #19832.

Instead.. isn't it frustrating while loading this movie ?
I guess we should do something about that incredible slowness in loading/parsing.

Sandro Santilli <strk>
Project Member
Thu 23 Aug 2007 12:36:15 PM UTC, comment #2:

0.8.1 works fine, no problems there, so it must be something in HEAD.

Can't try ffmpeg, but can you reproduce this in HEAD?

gui/gnash http://www.atomfilms.com/afassets/flash/nj_chapterninjai10_bb.swf

Udo Giacomozzi <udog>
Project Member
Thu 23 Aug 2007 11:57:48 AM UTC, comment #1:

Please also check with the 0.8.1 branch, and/or with ffmpeg

Sandro Santilli <strk>
Project Member
Wed 22 Aug 2007 10:03:16 AM UTC, original submission:

When playing Ninjai movies (www.ninjai.com) I hear lots of strange sound problems (mainly in the background tune). It sounds much like MP3 decoding errors.

It's definitely not looping or skipping sound buffers, it's much more distorted...

It doesn't seem to be related on processor load, as there is much CPU time left (and FPS is constantly at 24)

$ gui/gnash -V
Gnash cvs
Copyright (C) 2005-2007 Free Software Foundation, Inc.
Gnash comes with NO WARRANTY, to the extent permitted by law.
You may redistribute copies of Gnash under the terms of the GNU General
Public License. For more information, see the file named COPYING.
Build options cvs
Target:
Renderer: agg - GUI: GTK - Media handler: gst
Configured with: --disable-debugger --enable-renderer=agg --enable-gui=gtk --disable-cygnal --enable-media=GST --with-pixelformat=RGB24,BGRA32,RGBA32 --enable-fps-debug --disable-klash --enable-mit-shm
Gstreamer version is: 0.10.10.

Udo Giacomozzi <udog>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by tgc (Updated the item)
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by udog (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 11 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 04 Oct 2007 07:58:39 AM UTCstrkStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Wed 03 Oct 2007 09:46:23 PM UTCtgcStatusNone=>Ready For Test
    Wed 26 Sep 2007 09:45:02 AM UTCstrkStatusIn Progress=>None
      Assigned tostrk=>tgc
    Tue 25 Sep 2007 06:06:56 PM UTCstrkStatusReady For Test=>In Progress
      Assigned totgc=>strk
      SummarySound problems playing Ninjai movies=>Performance problems playing Ninjai movies
    Wed 05 Sep 2007 01:06:08 PM UTCtgcStatusNone=>Ready For Test
    Thu 23 Aug 2007 11:57:48 AM UTCstrkCategoryNone=>sound
      Assigned toNone=>tgc

    Back to the top


    Powered by Savane 3.1-cleanup1