bugGnash - The GNU Flash player - Bugs: bug #20796, Gnash doesn't deal well with...

 
 

bug #20796: Gnash doesn't deal well with 'malformed' SWF7

Submitted by:  None
Submitted on:  Thu 16 Aug 2007 12:59:12 PM UTC  
 
Category: coreSeverity: 5 - Blocker
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Sandro Santilli <strk>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sat 18 Aug 2007 05:26:45 AM UTC, comment #6:

We should add such interesting movies in the wiki (ExternalFlashMovies)

Sandro Santilli <strk>
Project MemberIn charge of this item.
Sat 18 Aug 2007 05:24:41 AM UTC, comment #5:

It now works for me (I was the original reporter).

And very interesting it is too, now that I can see it.

Benjamin Wolsey <bwy>
Project Member
Sat 18 Aug 2007 05:05:17 AM UTC, comment #4:

Committed in head and 0.8.1 branch. Ready for test.
Rob, we'd need a 'parser' category for the bugs tracker.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Sat 18 Aug 2007 04:50:15 AM UTC, comment #3:

Extracted jpeg image-001.jpg was slightly too large for savannah. Find it re-attached as a bzip2 archive.

(file #13687)

Ivor Blockley <meteoryte>
Sat 18 Aug 2007 04:44:13 AM UTC, comment #2:

Attached are the two jpeg images I extracted from thames10_416x340.swf

I used swf_extractor.py from hairchoir (http://hachoir.org/browser/trunk/hachoir-tools/swf_extractor.py) to obtain these. No warnings during extraction. "eye of gnome" displays both images ok.

(file #13686)

Ivor Blockley <meteoryte>
Thu 16 Aug 2007 01:10:54 PM UTC, comment #1:

Gnash doesn't seem to hang, since it reaches the exit condition.
The only problem is that the parser is interrupted by an error in the embedded JPEG. A nicer handling could be just discarding the JPEG character. Would be worth a testcase containing intentionally malformed JPEG and see what the proprietary player does in that case.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Thu 16 Aug 2007 12:59:12 PM UTC, original submission:

http://news.bbc.co.uk/nol/shared/bsp/hi/uk/07/thames_barrier/swf/thames10_416x340.swf

Gnash thinks this SWF7 movie is malformed, which it may be. The main problem is that it makes Firefox hang.

Output:

[benjamin@franz Desktop]$ gnash http://news.bbc.co.uk/nol/shared/bsp/hi/uk/07/thames_barrier/swf/thames10_416x340.swf
8901] 14:56:56: Your X server expects RGB24 pixmap data for standard mode.
/home/benjamin/.themes/Gnursid/gtk-2.0/gtkrc:440: Bilddatei konnte nicht in pixmap_path gefunden werden: »check4.png«
/home/benjamin/.themes/Gnursid/gtk-2.0/gtkrc:443: Overlay image options specified without filename
8901] 14:56:56: Created top level window
8901] 14:56:56: framebuffer pixel format is RGB24
8901] 14:56:56: Base url set to: http://news.bbc.co.uk/nol/shared/bsp/hi/uk/07/thames_barrier/swf/thames10_416x340.swf
8901] 14:56:56: SECURITY: Load from host news.bbc.co.uk granted (default).
8901] 14:56:57: Movie http://news.bbc.co.uk/nol/shared/bsp/hi/uk/07/thames_barrier/swf/thames10_416x340.swf (SWF7) added to library
8901] 14:56:57: GTK-AGG: 450000 bytes offscreen buffer allocated

8901] 14:56:57: initialized AGG buffer <0x2b5bf4fbc010>, 450000 bytes, 416x340, rowsize is 1248 bytes
8901] 14:56:57: ERROR: *** no tag loader for type 88 (movie)
8901] 14:56:57: MALFORMED SWF: Internal jpeg error: Not a JPEG file: starts with 0x%02x 0x%02x
8901] 14:56:57: MALFORMED SWF: Internal jpeg error: Not a JPEG file: starts with 0x%02x 0x%02x
8901] 14:56:57: MALFORMED SWF: Internal jpeg error: Unsupported marker type 0x%02x
8901] 14:56:57: MALFORMED SWF: Internal jpeg error: Not a JPEG file: starts with 0x%02x 0x%02x
8901] 14:56:57: MALFORMED SWF: Internal jpeg error: Unsupported marker type 0x%02x
8901] 14:56:57: MALFORMED SWF: Internal jpeg error: Not a JPEG file: starts with 0x%02x 0x%02x
8901] 14:56:57: MALFORMED SWF: Internal jpeg error: Unsupported marker type 0x%02x
8901] 14:56:57: ERROR: Parsing exception: errors during JPEG header parsing
8901] 14:57:05: DEBUG: static gboolean gnash::GtkGui::delete_event(GtkWidget, GdkEvent, void*) enter
Main loop ended, cleaning up
Any segfault past this message is likely due to improper threads cleanup.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #13687:  image-001.jpg.bz2 added by meteoryte (508KiB - application/x-bzip - the image that failed to upload last time)
file #13686:  image-002.jpg added by meteoryte (41KiB - image/jpeg - Images extracted from thames10_416x340.swf)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bwy (Posted a comment)
  • -unavailable- added by meteoryte (Updated the item)
  • -unavailable- added by strk (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 18 Aug 2007 05:26:45 AM UTCstrkStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Sat 18 Aug 2007 05:05:17 AM UTCstrkCategoryNone=>core
      StatusNone=>Ready For Test
    Sat 18 Aug 2007 04:50:14 AM UTCmeteoryteAttached File-=>Added image-001.jpg.bz2, #13687
    Sat 18 Aug 2007 04:44:13 AM UTCmeteoryteAttached File-=>Added image-002.jpg, #13686
    Thu 16 Aug 2007 01:10:54 PM UTCstrkSeverity3 - Normal=>5 - Blocker
      Assigned toNone=>strk
      Carbon-Copy-=>Added zoulunkai

    Back to the top


    Powered by Savane 3.1-cleanup1