bugGNU Wget - Bugs: bug #20748, append_uri_pathel needs to...

 
 

bug #20748: append_uri_pathel needs to zero-terminate the string

Submitted by:  Micah Cowan <micahcowan>
Submitted on:  Fri 10 Aug 2007 07:08:57 PM UTC  
 
Category: Crash/Freeze/InfloopSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed In Repository
Privacy: PublicAssigned to: None
Originator Name: Open/Closed: Closed
Release: NoneOperating System: None
Reproducibility: NoneFixed Release: 1.11
Planned Release: 1.11Regression: None
Work Required: NonePatch Included: Yes

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 10 Aug 2007 07:08:57 PM UTC, original submission:

Hello,

the test suite fails one test for me on GNU/Linux due to an
unterminated string in test_append_uri_pathel. Also, valgrind found
that append_uri_pathel at one point wrongly assumes a string to be
zero-terminated.

Now, I don't know what your coding conventions are:
- have growable strings be zero-terminated all the time, or
- only zero-terminate at the very end of the operation (thus not in
append_uri_pathel).

Since the rest of the code looked like the latter, I assumed that in the
patch below, which should fix these issues, and updates the copyright
year, which I forgot to do in the other patch for url.c. Apologies also
for posting a wrongly formatted ChangeLog entry, I had not yet adjusted
my vc-chlog configuration for multiple ChangeLog files.

Again, I've not given thought to security ramifications of this issue.

I've noticed other (spurious?) test failures at times, but have not
been able to analyze these yet, sorry.

Cheers,
Ralf

Micah Cowan <micahcowan>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by micahcowan (Submitted the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 16 Aug 2007 08:41:33 AM UTCmicahcowanStatusNone=>Fixed In Repository
      Open/ClosedOpen=>Closed
      Fixed ReleaseNone=>1.11

    Back to the top


    Powered by Savane 3.1-cleanup1