Fri 10 Aug 2007 07:08:57 PM UTC, original submission:
Hello,
the test suite fails one test for me on GNU/Linux due to an
unterminated string in test_append_uri_pathel. Also, valgrind found
that append_uri_pathel at one point wrongly assumes a string to be
zero-terminated.
Now, I don't know what your coding conventions are:
- have growable strings be zero-terminated all the time, or
- only zero-terminate at the very end of the operation (thus not in
append_uri_pathel).
Since the rest of the code looked like the latter, I assumed that in the
patch below, which should fix these issues, and updates the copyright
year, which I forgot to do in the other patch for url.c. Apologies also
for posting a wrongly formatted ChangeLog entry, I had not yet adjusted
my vc-chlog configuration for multiple ChangeLog files.
Again, I've not given thought to security ramifications of this issue.
I've noticed other (spurious?) test failures at times, but have not
been able to analyze these yet, sorry.
Cheers,
Ralf
|