bugGnash - The GNU Flash player - Bugs: bug #20741, Building gnash on OS/2

 
 

bug #20741: Building gnash on OS/2

Submitted by:  Paul Smedley <psmedley>
Submitted on:  Fri 10 Aug 2007 02:47:16 AM UTC  
 
Category: buildSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Sandro Santilli <strk>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 11 Aug 2007 05:40:58 AM UTC, comment #4:

I updated from CVS and it still builds - good to close as far as I can tell!

Paul Smedley <psmedley>
Fri 10 Aug 2007 02:09:11 PM UTC, comment #3:

Patch applied. I have no OS/2 to test, but build continues to work fine for me.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Fri 10 Aug 2007 12:38:39 PM UTC, comment #2:

Revised patch attached.

(file #13641)

Paul Smedley <psmedley>
Fri 10 Aug 2007 04:33:00 AM UTC, comment #1:

A few comments:

- The patch of log.h doesn't check for _OS2_ (SIZET_FMT). Also, SIZET_FMT should be defined in config.h, and detected by configure.
- The patch in container.h undefined HAVE_WINSOCK_H with apparently no reason (the ifdefs are changed to check both HAVE_WINSOCK_H and _OS2_
- The patches in network.h, shm.h, shm.cpp, dumpshm.h also undefines HAVE_WINSOCK_H while I'd prefer to change the ifdefs below, like it was done in container.h
- config.h doesn't have to be patches since it's a generated file, from config.h.in by configure

Please add a comment at the end of the #endif to give better context of what's being closed.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Fri 10 Aug 2007 02:47:16 AM UTC, original submission:

Please find attached a diff for building on OS/2

Feedback appreciated - currently only SDL & AGG are tested.

Paul Smedley <psmedley>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #13641:  os2.diff added by psmedley (9KiB - text/x-diff - Updated based on suggestions)
file #13637:  os2.diff added by psmedley (8KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by psmedley (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 11 Aug 2007 07:07:50 AM UTCstrkStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Fri 10 Aug 2007 02:09:11 PM UTCstrkStatusNone=>Ready For Test
      Assigned toNone=>strk
    Fri 10 Aug 2007 12:38:39 PM UTCpsmedleyAttached File-=>Added os2.diff, #13641
    Fri 10 Aug 2007 02:47:16 AM UTCpsmedleyAttached File-=>Added os2.diff, #13637

    Back to the top


    Powered by Savane 3.1-cleanup1