bugGNU Wget - Bugs: bug #20736, wget.m4 adjustments

 
 

bug #20736: wget.m4 adjustments

Submitted by:  Micah Cowan <micahcowan>
Submitted on:  Thu 09 Aug 2007 07:03:38 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed In Repository
Privacy: PublicAssigned to: None
Originator Name: Open/Closed: Closed
Release: NoneOperating System: None
Reproducibility: NoneFixed Release: 1.11
Planned Release: 1.11Regression: None
Work Required: NonePatch Included: Yes

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 09 Aug 2007 07:03:38 PM UTC, original submission:

Hello wget-patchers,

The serial number of a macro file should come early in the file,
before any macro definitions, and be bumped up upon changes, or
should be deleted. Also, some AC_DEFUNs lack needed quotation.

This may not be important now, but if Wget moves to use Automake
then it will. I may be sending patches to that end.

Cheers,
Ralf

2007-08-09 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>

  • m4/wget.m4 (WGET_PROCESS_PO, AM_PATH_PROG_WITH_TEST): Add

missing M4 quotation. Delete serial number.

Index: m4/wget.m4
===================================================================
--- m4/wget.m4 (revision 2332)
+++ m4/wget.m4 (working copy)
@@ -1,5 +1,5 @@
dnl Wget-specific Autoconf macros.
-dnl Copyright (C) 1996-2005 Free Software Foundation, Inc.
+dnl Copyright (C) 1996-2005, 2007 Free Software Foundation, Inc.

dnl This program is free software; you can redistribute it and/or modify
dnl it under the terms of the GNU General Public License as published by
@@ -332,7 +334,7 @@
dnl This is not strictly an Autoconf macro, because it is run from
dnl within `config.status' rather than from within configure. This
dnl is why special rules must be applied for it.
-AC_DEFUN(WGET_PROCESS_PO,
+AC_DEFUN([WGET_PROCESS_PO],
[
dnl I wonder what the following several lines do...
if test "x$srcdir" != "x."; then
@@ -364,11 +366,9 @@
# functionality. Please note that the actual code is not freely
# available.

-# serial 1
-
dnl AM_PATH_PROG_WITH_TEST(VARIABLE, PROG-TO-CHECK-FOR,
dnl TEST-PERFORMED-ON-FOUND_PROGRAM [, VALUE-IF-NOT-FOUND [, PATH]])
-AC_DEFUN(AM_PATH_PROG_WITH_TEST,
+AC_DEFUN([AM_PATH_PROG_WITH_TEST],
[# Extract the first word of "$2", so it can be a program name with args.
set dummy $2; ac_word=[$]2
AC_MSG_CHECKING([for $ac_word])

Micah Cowan <micahcowan>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by micahcowan (Submitted the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 16 Aug 2007 08:32:19 AM UTCmicahcowanStatusConfirmed=>Fixed In Repository
      Open/ClosedOpen=>Closed
      Fixed ReleaseNone=>1.11

    Back to the top


    Powered by Savane 3.1-cleanup1