bugGNU Wget - Bugs: bug #20735, url_string: use comparison, not...

 
 

bug #20735: url_string: use comparison, not assignment

Submitted by:  Micah Cowan <micahcowan>
Submitted on:  Thu 09 Aug 2007 06:57:03 PM UTC  
 
Category: Program LogicSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed In Repository
Privacy: PublicAssigned to: Micah Cowan <micahcowan>
Originator Name: Open/Closed: Closed
Release: NoneOperating System: None
Reproducibility: NoneFixed Release: 1.11
Planned Release: 1.11Regression: None
Work Required: NonePatch Included: Yes

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 09 Aug 2007 06:57:03 PM UTC, original submission:

Hello there,

I found a small buglet in wget sources. I'll leave it to someone
else to check whether this has security implications. ;-)

Cheers,
Ralf

2007-08-09 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>

  • src/url.c (url_string): Use comparison, not assignment.

Index: src/url.c
===================================================================
--- src/url.c (revision 2332)
+++ src/url.c (working copy)
@@ -1836,7 +1836,7 @@
quoted_user = url_escape_allow_passthrough (url->user);
if (url->passwd)
{
- if (auth_mode = URL_AUTH_HIDE_PASSWD)
+ if (auth_mode == URL_AUTH_HIDE_PASSWD)
quoted_passwd = HIDDEN_PASSWORD;
else
quoted_passwd = url_escape_allow_passthrough (url->passwd);

Micah Cowan <micahcowan>In charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by micahcowan (Submitted the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 16 Aug 2007 08:27:55 AM UTCmicahcowanStatusConfirmed=>Fixed In Repository
      Open/ClosedOpen=>Closed
      Fixed ReleaseNone=>1.11

    Back to the top


    Powered by Savane 3.1-cleanup1