bugGnash - The GNU Flash player - Bugs: bug #20696, Gnash not recognized as flash...

 
 

bug #20696: Gnash not recognized as flash player

Submitted by:  Benjamin Wolsey <bwy>
Submitted on:  Mon 06 Aug 2007 08:08:53 AM UTC  
 
Category: pluginSeverity: 4 - Important
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Sandro Santilli <strk>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 08 Aug 2007 08:53:38 PM UTC, comment #4:

Applied your patch. Consider sending other patches on top of that if you find other problems. Thanks.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Tue 07 Aug 2007 07:41:59 AM UTC, comment #3:

SWFobject (http://blog.deconcept.com/swfobject/swfobject_source.js) should also return the correct values for all versions if the start of the description contains a revision number and ends with a dot (like: "Shockwave Flash 8.0 r99. Gnash ..."). Otherwise it returns NaN for the revision, and that might possibly have unwanted consequences.

Benjamin Wolsey <bwy>
Project Member
Mon 06 Aug 2007 07:32:58 PM UTC, comment #2:

Anything works as long as the version number is in that form with whitespace before it. "Compatible with Flash 8.0 r99" or "Flash version 9.0 r0" or "twelve hungry aliens 11.0 r25" ... The possibilities are endless, though it probably ought to agree with the opening of the description: "Shockwave Flash 8.0" at present. I should think adding a highish revision number would be advisable.

Just a bit more information:

There are different issues with another allegedly common script, SWFobject, but I don't think they are really fixable and it works at present finding the major version number. (Reading from the first numeric character after whitespace it finds up to the first dot).

The script that's being touted as the successor to both UFO and SWFobject, SWFfix, uses the same method as UFO, but gets the minor version number as well (not just the major version and the revision number), so this change should cover that as well.

(file #13606)

Benjamin Wolsey <bwy>
Project Member
Mon 06 Aug 2007 06:04:46 PM UTC, comment #1:

Could you try with a string like [compatibile Flash 10.0 r0.] ?

Sandro Santilli <strk>
Project MemberIn charge of this item.
Mon 06 Aug 2007 08:08:53 AM UTC, original submission:

This is a problem with the javascript used to identify flash players, not gnash itself. Lots of sites (www.tagesschau.de, http://www.jibjab.com) seem to use the UFO script (which is licensed under the LGPL) to get the flash version.

UFO looks for the flash version in the last two words in navigator.plugins["Shockwave Flash"].description in the form "8.0 r1" It takes everything before the dot as the major version, everything after the r as the revision.

The attached mess of a script demonstrates this by adding a string to the end of the gnash description.

This works for mozilla-type plugins. I haven't investigated the IE section.

I would suggest adding a string like "Flash 10.0 r0" (or whatever version it's advisable to try) to the end of the gnash description so that websites using UFO don't refuse to display flash.

Benjamin Wolsey <bwy>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #13603:  UFOversion.patch added by bwy (508B - text/x-patch - Right way round this time)
file #13602:  UFOversion.patch added by bwy (508B - text/x-patch - Adds a flash version to end of plugin description)
file #13601:  UFOtest.html added by bwy (1KiB - text/html - UFO script analysis)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by bwy (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 08 Aug 2007 08:53:38 PM UTCstrkStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Wed 08 Aug 2007 04:38:54 PM UTCstrkSeverity3 - Normal=>4 - Important
      Assigned toNone=>strk
    Mon 06 Aug 2007 07:32:58 PM UTCbwyAttached File-=>Added compatible_with_flash_version_8.0_r99.patch, #13606
    Mon 06 Aug 2007 06:04:46 PM UTCstrkCategoryNone=>plugin
    Mon 06 Aug 2007 08:44:24 AM UTCbwyAttached File-=>Added UFOversion.patch, #13603
    Mon 06 Aug 2007 08:42:25 AM UTCbwyAttached File-=>Added UFOversion.patch, #13602
    Mon 06 Aug 2007 08:08:53 AM UTCbwyAttached File-=>Added UFOtest.html, #13601

    Back to the top


    Powered by Savane 3.1-cleanup1