bugGnash - The GNU Flash player - Bugs: bug #20665, [PATCH] use $pkglibdir for...

 
 

bug #20665: [PATCH] use $pkglibdir for unversioned libs

Submitted by:  Alexander Sack <asac>
Submitted on:  Thu 02 Aug 2007 04:57:50 PM UTC  
 
Category: buildSeverity: 5 - Blocker
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Sandro Santilli <strk>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Tue 15 Jan 2008 05:11:04 PM UTC, comment #14:

Rob said we can close this.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Thu 13 Dec 2007 07:08:09 PM UTC, comment #13:

Asac: you provided a patch to avoid installing the unversioned libs in public dirs, but rather in $pkglibdir. Your patch was applied.
That's all I guess.

The rest should be up for rsavoye, which seemed to have another plan for 0.8.2 as of comment #8

Sandro Santilli <strk>
Project MemberIn charge of this item.
Thu 13 Dec 2007 06:41:51 PM UTC, comment #12:

Hi,

would be easier for me to verify if you could summarize what the exact issue was and how you tried to fix it :).

- Alexander

Alexander Sack <asac>
Wed 12 Dec 2007 05:08:39 PM UTC, comment #11:

Rob, asac, is current HEAD ok with library stuff ?
Could you verify as we close 0.8.2 up ?

Sandro Santilli <strk>
Project MemberIn charge of this item.
Thu 22 Nov 2007 09:39:24 PM UTC, comment #10:

I tagged this as blocker so we remember to closely check before 0.8.2 is out. We want install of 0.8.2 to not use any lib from 0.8.1 (I'm afraid linking to libs installed by 0.8.0 would still be possible though, worth testing that too).

Sandro Santilli <strk>
Project MemberIn charge of this item.
Thu 22 Nov 2007 09:25:39 PM UTC, comment #9:

This bug report from gentoo user seems related to library versioning

http://bugs.gentoo.org/show_bug.cgi?id=200021

Sandro Santilli <strk>
Project MemberIn charge of this item.
Fri 10 Aug 2007 05:16:40 PM UTC, comment #8:

The compromise is I don't have to finish making everything convenience libs, which is how I really wanted to fix this bug. :-) I'll worry about changing this when I finish that for 0.8.2.

Rob Savoye <rsavoye>
Project Administrator
Fri 10 Aug 2007 05:09:08 PM UTC, comment #7:

... if its not ment as a library then why is putting the libs into $pkglibdir a compromise? IMO, its just the right way to go then.

Alexander Sack <asac>
Fri 10 Aug 2007 04:58:24 PM UTC, comment #6:

Gnash will likely never be used as a flash rendering library, as I doubt the internal API will ever be that stable. Gnash has never been designed to be used this way. While I do believe this patch is unnecessary, I am willing to compromise on this if it makes life easier for package maintainers. It'll also let me not worry about finishing up making all Gnash libraries convenience libs immediately for the release.

Rob Savoye <rsavoye>
Project Administrator
Fri 10 Aug 2007 04:02:11 PM UTC, comment #5:

... and I agree with Sandro: As long as you don't install headers, please keep things in pkglibdir ...

Alexander Sack <asac>
Fri 10 Aug 2007 03:59:43 PM UTC, comment #4:

my comment is:

if you cannot commit to track binary compatibility for real atm, please use pkglibdir and keep this patch.

Using --release (as you do) doesn't improve the situation much, so imo it doesn't make a difference.

So my suggestion: just keep your libs in pkglibdir until you have a stable abi/api.

Alexander Sack <asac>
Fri 10 Aug 2007 01:46:55 PM UTC, comment #3:

I interpreted "unversioned" as "not meant for public use" so the patch seemed fine to me. I know gnash releases are versioned, 0.8.1 is already versioned. Still we don't install any header so no foreign code can use the libs.
This suggest me we should put the libs in a gnash-specific directory.

Does it make sense ?

Sandro Santilli <strk>
Project MemberIn charge of this item.
Fri 10 Aug 2007 01:45:50 PM UTC, comment #2:

rob said:

Like I said yesterday, this is not a bug, please back
this patch out,
All Gnash releases have version numbers, so this doesn't really
apply.
As packagers shouldn't be building from CVS, this doesn't really apply.
In the near future we'll be statically linking the gnash libs into the
player, at which point this won't effect us at all anymore. I got mos of
the changes made, and just need to find the time to finish. (hard when
at a conference)

Sandro Santilli <strk>
Project MemberIn charge of this item.
Fri 10 Aug 2007 04:36:37 AM UTC, comment #1:

applied to both 0.8.1 branch and head.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Thu 02 Aug 2007 04:57:50 PM UTC, original submission:

you don't version your libraries, thus they have to stay out of system lib directory. The solution is to ship them in $pkglibdir. The patch I attach tackles this.

Alexander Sack <asac>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #13554:  use_pkglibdir_for_unversioned_libs.patch added by asac (6KiB - text/x-patch - install libs in pkglibdir)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rsavoye (Posted a comment)
  • -unavailable- added by strk (Updated the item)
  • -unavailable- added by asac (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 15 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 15 Jan 2008 05:11:04 PM UTCstrkStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Thu 22 Nov 2007 09:39:24 PM UTCstrkSeverity4 - Important=>5 - Blocker
    Fri 10 Aug 2007 04:58:24 PM UTCrsavoyeSeverity5 - Blocker=>4 - Important
    Fri 10 Aug 2007 01:45:50 PM UTCstrkStatusFixed=>Ready For Test
      Open/ClosedClosed=>Open
    Fri 10 Aug 2007 04:36:37 AM UTCstrkStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Fri 10 Aug 2007 04:03:23 AM UTCstrkStatusNone=>In Progress
      Assigned torsavoye=>strk
    Thu 02 Aug 2007 05:44:22 PM UTCstrkCategoryNone=>build
      Severity3 - Normal=>5 - Blocker
      Assigned toNone=>rsavoye
      Summary[PATH] use $pkglibdir for unversioned libs=>[PATCH] use $pkglibdir for unversioned libs
    Thu 02 Aug 2007 04:57:50 PM UTCasacAttached File-=>Added use_pkglibdir_for_unversioned_libs.patch, #13554

    Back to the top


    Powered by Savane 3.1-cleanup1