bugPSPP - Bugs: bug #20606, Allow system/portable files on...

 
 

bug #20606: Allow system/portable files on command line

Submitted by:  Ben Pfaff <blp>
Submitted on:  Sat 28 Jul 2007 02:21:51 AM UTC  
 
Category: System/Portable File I/OSeverity: 1 - Wishlist
Status: FixedAssigned to: None
Open/Closed: ClosedRelease: Before 1.0
Effort: 0.00

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sat 08 Nov 2008 04:28:56 AM UTC, comment #9:

I checked in a patch for this. Closing this item.

John Darrington <jmd>
Project Administrator
Tue 04 Nov 2008 11:45:17 PM UTC, comment #8:

> Oh, also: should there be any documentation update as part of this? Or NEWS?


The documentation definitely needs updating. I'm not sure about NEWS. It's quite possible that further changes will occur before the next release, which will obsolete any NEW entry.

> I am not a fan of the command_line_processor_replace_aux function. I think that, instead, it would be possible to use a pointer to a pointer. For me, that would be easier to understand.


It would make the implementation easier to understand, but would make usage harder. If we did that, then it would be neccessary to either use a global void ** for each option group or propagate them from main to initialise. I was trying to keep that sort of thing to a minimum.

All your other points I think are valid.

John Darrington <jmd>
Project Administrator
Tue 04 Nov 2008 06:37:33 AM UTC, comment #7:

Oh, also: should there be any documentation update as part of this? Or NEWS?

Ben Pfaff <blp>
Project Administrator
Tue 04 Nov 2008 05:44:33 AM UTC, comment #6:

Shouldn't this add the "argp" module to Smake?

I had to stare at the code for quite a while before I understood it. I think that is partly just because argp is somewhat convoluted in design, which in turn forces convoluted workarounds. In the end I am not certain that argp is a win, but I guess I don't really object to it either.

I am not a fan of the command_line_processor_replace_aux function. I think that, instead, it would be possible to use a pointer to a pointer. For me, that would be easier to understand.

Please don't put __ at the beginning of an identifier (__SRC_UI_COMMAND_LINE_H), as such identifiers are reserved.

Please capitalize SPSS and PSPP in user strings (e.g. in "PSPPIRE --- A user interface for pspp" and "Set to `compatible' if you want only to accept spss compatible syntax").

I think there's a punctuator missing in the string "PSPP A program for statistical analysis"

I don't entirely understand the grouping. It looks like, in the terminal ui, the top level has the terminal as a subgroup, which has two subgroups underneath it. This requires adding another level of propagation of aux data, which is a pain. Would it be easier to just add the two terminal subgroups directly under the top level? Then there would be no need for the additional level of aux data propagation, I think. That's if I understand what's going on, which I might not.

Ben Pfaff <blp>
Project Administrator
Sun 02 Nov 2008 05:18:18 AM UTC, comment #5:

This patch rewrites the command line processing using argp, and attempts to share the common options between pspp and psppire so far as possible.

Options which were previously documented as "unimplemented" I have removed. Also, the -c option has been removed, since it did nothing except cause a seg fault.

It also allows psppire to optionally take a single por or sav file on the command line, and will open it using IMPORT or GET as appropriate. When/if we allow multiple datasets, it might make sense to allow more than one filename to be given, but currently, one is the limit.

(file #16773)

John Darrington <jmd>
Project Administrator
Mon 13 Oct 2008 02:59:07 PM UTC, comment #4:

See also the useful points of discussion in bug #23182, which otherwise duplicates this bug.

Ben Pfaff <blp>
Project Administrator
Tue 21 Aug 2007 02:57:48 AM UTC, comment #3:

>Should this be done before or after the next release?


Ideally before but I wouldn't let it block release. Hence I'm setting it to post-0.6.0.

Ben Pfaff <blp>
Project Administrator
Sat 18 Aug 2007 02:58:55 AM UTC, comment #2:

Should this be done before or after the next release?

John Darrington <jmd>
Project Administrator
Sat 28 Jul 2007 06:31:16 AM UTC, comment #1:

The same should happen for the gui.

Many of the command line flags for pspp and psppire will be common. So it would make sense to have a single function to parse the common arguments.

John Darrington <jmd>
Project Administrator
Sat 28 Jul 2007 02:21:51 AM UTC, original submission:

It would be nice if a command such as
pspp foo.sav
would do an implicit 'GET "foo.sav".' instead of trying to parse foo.sav as a syntax file.

Ben Pfaff <blp>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #16773:  cmd-line-args.patch added by jmd (40KiB - text/x-diff)

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -unavailable- added by jmd (Posted a comment)
  • -unavailable- added by blp (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 08 Nov 2008 04:28:56 AM UTCjmdStatusReady for Test/Review=>Fixed
      Open/ClosedOpen=>Closed
    Sun 02 Nov 2008 05:18:18 AM UTCjmdStatusNone=>Ready for Test/Review
    Sun 02 Nov 2008 05:18:17 AM UTCjmdAttached File-=>Added cmd-line-args.patch, #16773
    Sat 25 Oct 2008 10:01:10 PM UTCblpReleasePost-0.6.0=>Before 1.0
    Sun 11 May 2008 12:39:25 PM UTCjmdDependencies-=>bugs #23182 is dependent
    Tue 21 Aug 2007 02:57:48 AM UTCblpReleaseNone=>Post-0.6.0

    Back to the top


    Powered by Savane 3.1-cleanup1