bugGnash - The GNU Flash player - Bugs: bug #20463, "gnash" accepts multiple...

 
 

bug #20463: "gnash" accepts multiple filenames but only plays the first one

Submitted by:  Martin Guy <martinwguy>
Submitted on:  Thu 12 Jul 2007 12:26:30 PM UTC  
 
Category: NoneSeverity: 2 - Minor
Release: NoneStatus: None
Privacy: PublicAssigned to: Sandro Santilli <strk>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 25 Aug 2010 11:42:25 AM UTC, comment #3:

This comes effectively under re-entrancy.

Benjamin Wolsey <bwy>
Project Member
Thu 16 Aug 2007 12:31:02 PM UTC, comment #2:

Gnash core libs are not ready to play multiple files.
In order to be ready, we should implement a VM::reset() interface
and make sure NO as_objects will be alive at the end of that function (as they contain a reference to the old VM).

Most likely, there'll be also other places to analize to make
sure things work. A quick hack on the testsuite scripts should
help testing this out (ie: run all tests in all versions by a single 'gnash' invokation rather then multiple ones and verify no unexpected failures/successes are introduced).

Sandro Santilli <strk>
Project MemberIn charge of this item.
Thu 16 Aug 2007 11:07:11 AM UTC, comment #1:

Something like the attached patch would do it, but the code round there is a bit of a mess. Is the commented out code properly obsolete?

// get the file name from the command line
while (optind < argc) {

#if 0 // Options setting variables should use the getopt style!
// Some options set variables, like ip=127.0.0.1
if (argc > 2 && strchr(argv[optind], '=')) {
log_error (_("Got variable option (%s) on command line"),
argv[optind]);
} else {
#endif
infile = argv[optind];
}
break;
#if 0 // see above
}
#endif
optind++;
}

(file #13671)

Benjamin Wolsey <bwy>
Project Member
Thu 12 Jul 2007 12:26:30 PM UTC, original submission:

We can only play one file at a time because the VM is set up according to the flash version in the first file it plays.

However, the standalone player silently accepts multiple filenames, of which it only plays the first one.

Martin Guy <martinwguy>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by bwy (Updated the item)
  • -unavailable- added by martinwguy (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 25 Aug 2010 11:42:25 AM UTCbwyOpen/ClosedOpen=>Closed
    Thu 16 Aug 2007 12:31:02 PM UTCstrkAssigned toNone=>strk
    Thu 16 Aug 2007 11:07:10 AM UTCbwyAttached File-=>Added explicit_about_ignoring_files.patch, #13671

    Back to the top


    Powered by Savane 3.1-cleanup1