bugGNU Wget - Bugs: bug #20430, Tests need to be a bit more...

 
 

bug #20430: Tests need to be a bit more verbose.

Submitted by:  Micah Cowan <micahcowan>
Submitted on:  Tue 10 Jul 2007 08:26:37 AM UTC  
 
Category: TestingSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed In Repository
Privacy: PublicAssigned to: Joshua David Williams <yurimxpxman>
Originator Name: Open/Closed: Closed
Release: NoneOperating System: None
Reproducibility: NoneFixed Release: 1.11
Planned Release: 1.11Regression: None
Work Required: NonePatch Included: Yes

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Tue 17 Jul 2007 01:02:21 AM UTC, comment #6:

Code for this is now in the repo, under the appropriate bug branch. Just needs to be verified and merged in! :)

Micah Cowan <micahcowan>
Sat 14 Jul 2007 06:47:40 PM UTC, comment #5:

It doesn't make much difference in this case, but I prefer to avoid printf() in favor of fputs() and puts(), when no formats are involved.

Micah Cowan <micahcowan>
Sat 14 Jul 2007 12:54:39 AM UTC, comment #4:

Here's a patch file of your code (minus the typos :)

(file #13336)

Joshua David Williams <yurimxpxman>In charge of this item.
Fri 13 Jul 2007 08:10:01 PM UTC, comment #3:

Ick, Savannah totally butchered my indentation.

Micah Cowan <micahcowan>
Fri 13 Jul 2007 08:09:11 PM UTC, comment #2:

Actually, I'd prefer that the solution be rolled into the definition of mu_run_test, if possible. That is, you could have it do exactly as your patch does, but instead of writing

printf ("RUNNING TEST text_prase_content_disposition...\n");
mu_run_test (test_parse_content_disposition);
printf ("PASSED\n\n");

printf ("RUNNING TEST test_subdir_p...\n");
mu_run_test (test_subdir_p);
printf ("PASSED\n\n");

...

You could just have mu_run_test do the work for you (untested):

#define mu_run_test(test) \
do {\
const char *message;\
puts ("RUNNING TEST " #test "...");
message = test();\
tests_run++;\
if (message) return message;\
else puts ("PASSED\n");\
} while (0)

Micah Cowan <micahcowan>
Fri 13 Jul 2007 07:23:15 PM UTC, comment #1:

This patch prints the names of each test run.

(file #13335)

Joshua David Williams <yurimxpxman>In charge of this item.
Tue 10 Jul 2007 08:26:37 AM UTC, original submission:

ALL TESTS PASSED
Tests run: 7

doesn't quite cut it for me... need to know at least the names of the tests that are running.

Micah Cowan <micahcowan>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #13336:  testverb.patch added by yurimxpxman (970B - text/x-patch)
file #13335:  testverb.diff added by yurimxpxman (1KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by yurimxpxman (Updated the item)
  • -unavailable- added by micahcowan (Submitted the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 11 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 29 Jul 2007 01:30:02 AM UTCmicahcowanStatusInspected=>Fixed In Repository
      Open/ClosedOpen=>Closed
      Fixed ReleaseNone=>1.11
    Sat 14 Jul 2007 06:47:40 PM UTCmicahcowanStatusAwaiting Approval=>Inspected
    Sat 14 Jul 2007 12:54:39 AM UTCyurimxpxmanAttached File-=>Added testverb.patch, #13336
    Fri 13 Jul 2007 07:23:15 PM UTCyurimxpxmanAttached File-=>Added testverb.diff, #13335
      StatusIn Progress=>Awaiting Approval
      Patch IncludedNone=>Yes
    Fri 13 Jul 2007 06:39:12 PM UTCmicahcowanAssigned toNone=>yurimxpxman
    Fri 13 Jul 2007 06:35:58 PM UTCyurimxpxmanStatusConfirmed=>In Progress
    Tue 10 Jul 2007 08:28:54 AM UTCmicahcowanPlanned ReleaseNone=>1.11

    Back to the top


    Powered by Savane 3.1-cleanup1