bugPSPP - Bugs: bug #20427, Portable file writer doesn't write...

 
 

bug #20427: Portable file writer doesn't write weight variable

Submitted by:  Ben Pfaff <blp>
Submitted on:  Tue 10 Jul 2007 04:40:06 AM UTC  
 
Category: System/Portable File I/OSeverity: 5 - Average
Status: FixedAssigned to: None
Open/Closed: ClosedRelease: None
Effort: 0.00

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 25 Jul 2007 04:11:01 AM UTC, comment #3:

>Maybe this reflects some of your other recent patches.


Yes it does. Sorry about that. I've switched to using "quilt" for managing my stack of patches (highly recommended BTW). It makes it so easy to cherry-pick patches out of a pile that sometimes I forget to make sure they're independent.

I checked this in.

Thanks for the review.

Ben Pfaff <blp>
Project Administrator
Mon 23 Jul 2007 01:25:33 AM UTC, comment #2:

After applying this patch, compilation fails with
src/data/por-file-writer.c:319: error: too many arguments to function 'var_get_short_name'
Maybe this reflects some of your other recent patches.

I don't see any other problems.

John Darrington <jmd>
Project Administrator
Sun 22 Jul 2007 05:05:17 AM UTC, comment #1:

Here's a proposed fix.

(file #13426)

Ben Pfaff <blp>
Project Administrator
Tue 10 Jul 2007 04:40:06 AM UTC, original submission:

The portable file reader reads the weight variable from portable files, but the portable file writer doesn't write the weight variable. We should fix this.

Ben Pfaff <blp>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jmd (Posted a comment)
  • -unavailable- added by blp (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 25 Jul 2007 04:11:01 AM UTCblpStatusReady for Test/Review=>Fixed
      Open/ClosedOpen=>Closed
    Sun 22 Jul 2007 05:05:17 AM UTCblpAttached File-=>Added weight-for-por-file-writer.patch, #13426
      StatusNone=>Ready for Test/Review

    Back to the top


    Powered by Savane 3.1-cleanup1