bugGnash - The GNU Flash player - Bugs: bug #20258, When a sprite in a movie has sound...

 
 

bug #20258: When a sprite in a movie has sound it does not play the sound.

Submitted by:  None
Submitted on:  Mon 25 Jun 2007 07:09:29 PM UTC  
 
Category: soundSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Tomas Groth <tgc>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 05 Jul 2007 06:48:06 PM UTC, comment #4:

My question is if for a single SWF file there is a SINGLE dictionary or multiple ones (one for each sprite).
In particular for sounds.

If only a central dictionary has to exist, then the gnash way
of proxying to the main movie should be fine, otherwise we'll
need to work a bit to avoid character id clashes.

In any case the MALFORMED SWF message seems to be safe to remove.
Maybe we shoudl raise a malformed SWF message when a duplicated
ID is attempted to be registered in the main dictionary instead
(might be already there)

Sandro Santilli <strk>
Project Member
Wed 04 Jul 2007 11:52:29 AM UTC, comment #3:

SoundStreamHead(2) and SoundStreamBlock Tags are allowed in SWFSprites. SoundStreamBlock tags contain soundsamples.
The player is in charge for mixing the several streams together.

Also allowed are StartSound tags. But these only have a reference to a DefineSound character in the main dictionary.

Klaus

Anonymous
Tue 03 Jul 2007 12:58:50 AM UTC, comment #2:

Let's wait for Klaus to tell us if sprites with sound are legal.
Also, if they do are legal, can a movie and the sprites in it contained have sounds samples with the same ID ?
I mean, should they be in two separate container or not ?

Sandro Santilli <strk>
Project Member
Mon 02 Jul 2007 02:42:41 PM UTC, comment #1:

Patch commited. Should the malformed-swf warning be removed?

Tomas Groth <tgc>In charge of this item.
Mon 25 Jun 2007 07:09:29 PM UTC, original submission:

I got a swf that has a sprite and inside the sprite there is a sound, when played the sound does not get played.

In the file /server/parser/sprite_definition.h you can see:

virtual void add_sound_sample(int /id/, sound_sample* /sam/)
{
IF_VERBOSE_MALFORMED_SWF (
log_swferror(_("add sam appears in sprite tags"));
);
}

These function gets called, so a try:

virtual void add_sound_sample(int id, sound_sample* sam)
{
IF_VERBOSE_MALFORMED_SWF (
log_swferror(_("add sam appears in sprite tags"));
);
m_movie_def->add_sound_sample(id,sam);

}

With that change the sound gets played. I seems that it was allready planned but maybe it is not implemented for some reason.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by tgc (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 05 Jul 2007 07:29:35 PM UTCstrkStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Tue 03 Jul 2007 12:58:50 AM UTCstrkStatusNone=>Ready For Test
      Assigned toNone=>tgc
      Carbon-Copy-=>Added -unavailable-

    Back to the top


    Powered by Savane 3.1-cleanup1