bugGnash - The GNU Flash player - Bugs: bug #20177, Youtube: half the video hidden

 
 

bug #20177: Youtube: half the video hidden

Submitted by:  Tomas Groth <tgc>
Submitted on:  Thu 14 Jun 2007 10:42:33 PM UTC  
 
Category: ActionScriptSeverity: 4 - Important
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Sandro Santilli <strk>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Tue 24 Jul 2007 01:23:47 AM UTC, comment #11:

You fetch gnash from CVS and build it, or wait for upcoming 0.8.1 release.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Tue 24 Jul 2007 12:53:59 AM UTC, comment #10:

How or what do I do to get rid of the half video? this bug has been called fixed.

Brian <ubuntubrian>
Mon 09 Jul 2007 01:34:30 PM UTC, comment #9:

The bug was in video_stream_def::get_bound always returning a NULL boundary. BTW, I dn't understand how did it work at all, since video_stream_instance::display was passing that NULL bounds to the renderer as last argument to drawVideoFrame.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Mon 09 Jul 2007 12:12:56 PM UTC, comment #8:

Tracking the nan back I found that it is the result of 0/0 with one of the operands being the evaluated _level0.player.movie.videoDisplay._height
variable and the other being the evaluated
_level0.player.movie.videoDisplay._width

It seems an aspect-ratio thing.

Next step would be finding out what kind of object
_level0.player.movie.videoDisplay is....

Sandro Santilli <strk>
Project MemberIn charge of this item.
Sat 07 Jul 2007 01:19:26 PM UTC, comment #7:

Verbose output of _y setting during player2.swf playback:

Setting _y for character /player/movie/videoDisplay
New Y requested: nan
Current matrix: | 2.8123 0.000396729 -225 || 1.52588e-05 2.81232 -168.8 |
Translated matrix: | 2.8123 0.000396729 -225 || 1.52588e-05 2.81232 0 |

So the problem is that _y is set to nan, which in turn is evaluated
to 0 when it comes to matrix transform.
Adding special handling for NaN is likely NOT the fix. Rather we should inspect about why _y=NaN is requested.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Sat 07 Jul 2007 01:04:14 PM UTC, comment #6:

A smaller patch is just removing the _y gettersetter, which is found to be the one causing the problem. I'm researching about the reason for this, but I suspect bogus size inspector functions for the video_stream_instance class.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Sat 07 Jul 2007 12:36:38 PM UTC, comment #5:

The bug was introduced by adding support for character properties
in any video_stream_instance.
This simple patch fixes the half-video, but would make video instances not-proper classes (and fail the testcases most likely).
I write the patch here just to focus the problem:

Index: video_stream_instance.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/video_stream_instance.cpp,v
retrieving revision 1.31
diff -U 2 -r1.31 video_stream_instance.cpp
--- video_stream_instance.cpp 1 Jul 2007 10:54:26 -0000 1.31
+++ video_stream_instance.cpp 7 Jul 2007 12:36:10 -0000
@@ -167,5 +167,5 @@
set_prototype(getVideoInterface());

- attachVideoProperties(*this);
+ //attachVideoProperties(*this);
}

Sandro Santilli <strk>
Project MemberIn charge of this item.
Wed 04 Jul 2007 12:17:44 PM UTC, comment #4:

It's not, the 0.8.0 got branched and stabilized.

Markus Gothe <nihilus>
Project Member
Wed 04 Jul 2007 09:12:17 AM UTC, comment #3:

I have done a build (ubuntu feisty) from the cvs 2007 06 18 and the resultant plugin (carefully installed and confirmed from the about:plugins page) STILL gives me half-offset video on YouTube.com. Can someone tell me if a build from the source dated on 2007 06 18 is a version 0.8.0 build?

version: cvs20070618
renderer: opengl
GUI: gtk
Media handler: ffmpeg

ffmpeg version is: Lavc0d.51.11.0

yinch'07

yinch <yinch>
Sat 30 Jun 2007 09:19:53 PM UTC, comment #2:

I got the same half video :(

Dongxu Li <butdiene>
Thu 21 Jun 2007 10:32:37 PM UTC, comment #1:

Ah, I thought it was my computer setup at work that was fscked.

Markus Gothe <nihilus>
Project Member
Thu 14 Jun 2007 10:42:33 PM UTC, original submission:

Youtube got a new player which introduces a new issue: The video is moved down, so that about half the video is hidden, see the attached image. The issue is present with both agg and GL.
By some incredible stoke of luck the 0.8.0 release doesn't seem to suffer from this bug!

Tomas Groth <tgc>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #13059:  tubebug1.png added by tgc (40KiB - image/png)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by ubuntubrian (Posted a comment)
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by yinch (Posted a comment)
  • -unavailable- added by butdiene (Posted a comment)
  • -unavailable- added by nihilus (Posted a comment)
  • -unavailable- added by tgc (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 11 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 22 Jul 2007 11:45:57 PM UTCstrkOpen/ClosedOpen=>Closed
    Sun 22 Jul 2007 11:45:56 PM UTCstrkStatusReady For Test=>Fixed
    Mon 09 Jul 2007 01:34:31 PM UTCstrkCarbon-Copy-=>Added udog
    Mon 09 Jul 2007 01:34:30 PM UTCstrkStatusIn Progress=>Ready For Test
    Sat 07 Jul 2007 12:36:57 PM UTCstrkCategoryrenderer=>ActionScript
      Severity3 - Normal=>4 - Important
    Sat 07 Jul 2007 12:36:38 PM UTCstrkStatusConfirmed=>In Progress
      Assigned toNone=>strk
    Fri 06 Jul 2007 02:43:31 AM UTCflaschenCarbon-Copy-=>Added flaschen
    Thu 21 Jun 2007 10:32:37 PM UTCnihilusStatusNone=>Confirmed
    Thu 14 Jun 2007 10:42:33 PM UTCtgcAttached File-=>Added tubebug1.png, #13059

    Back to the top


    Powered by Savane 3.1-cleanup1