bugfindutils - Bugs: bug #20128, compilation failure in tree.c...

 
 

bug #20128: compilation failure in tree.c (4.3.6) on aix with gcc

Submitted by:  Michael Haubenwallner <haubi>
Submitted on:  Fri 08 Jun 2007 02:49:24 PM UTC  
 
Category:  find Severity:  3 - Normal
Item Group:  Compilation Failure Status:  Fixed
Privacy:  Public Assigned to:  James Youngman <jay>
Originator Name:  Open/Closed:  Closed
Release:  4.3.6 Fixed Release:  4.3.7

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 09 Jun 2007 12:23:16 PM UTC, comment #1: 

I adopted a more complex fix, which is

1. To verify that <config.h> was already included before defs.h in every case
2. To ensure that config.h is the first thing #included

We automatically verify (1) but not (2); I can't immediately think of a way to automate the verification of (2).   

See the attached patch.

(file #12989)

James Youngman <jay>
Project AdministratorIn charge of this item.
Fri 08 Jun 2007 02:49:24 PM UTC, original submission:  

Compiler-error is "conflicting types for 'fgetpos64'"
as well as for 'fseeko64', 'fsetpos64' and 'ftello64'
each within the gcc-fixincludes-copy of stdio.h.

Problem is that in find/tree.c <stdio.h> gets included before "config.h" somehow through <assert.h> or <stdlib.h>.

Thing is that "config.h" defines _LARGE_FILES, which changes these declarations, but they already have been declared while _LARGE_FILES was undefined because of the first include before "config.h".

The simple fix is to include "defs.h" as the very first header-file in find/tree.c.

For exact error (and 2line-patch if required) you may look at
http://thread.gmane.org/gmane.linux.gentoo.alt/2645/focus=2670

Thanks!

Michael Haubenwallner <haubi>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #12989:  sv-bug-20128.patch added by jay (8KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jay (Updated the item)
  • -email is unavailable- added by haubi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-06-09 jay Open/ClosedOpen => Closed
        Fixed ReleaseNone => 4.3.7
    2007-06-09 jay Attached File- => Added sv-bug-20128.patch, #12989
        StatusNone => Fixed
        Assigned toNone => jay

    Back to the top


    Powered by Savane 3.5