bugGnash - The GNU Flash player - Bugs: bug #20106, segfault in...

 
 

bug #20106: segfault in sound_handler::convert_raw_data

Submitted by:  Sandro Santilli <strk>
Submitted on:  Wed 06 Jun 2007 07:56:22 PM UTC  
 
Category: soundSeverity: 6 - Security
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Tomas Groth <tgc>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Fri 08 Jun 2007 06:20:21 AM UTC, comment #6:

compliments :)

Sandro Santilli <strk>
Project Member
Thu 07 Jun 2007 09:40:20 PM UTC, comment #5:

I get the bad sound, but no segfault. Maybe it's harder to reproduce these thread-issues on dual core cpus...

Tomas Groth <tgc>In charge of this item.
Thu 07 Jun 2007 04:56:51 PM UTC, comment #4:

mmm.. wasn't enough.
I don't get why with threading disabled I can't reproduce though so I'd keep inspecting in that direction.

BTW, tgc, can you reproduce it ?

(I hear the bad sound even with threading disabled, just no segfault)

Sandro Santilli <strk>
Project Member
Thu 07 Jun 2007 04:49:26 PM UTC, comment #3:

Disabling loader thread I can't reproduce the problem.
So my bet is that the parser and the main thead are sharing some data w/out mutex protection.
In particular it is likely the m_sound_samples.
I'm adding a mutex.

Sandro Santilli <strk>
Project Member
Thu 07 Jun 2007 10:45:52 AM UTC, comment #2:

That build error is not related, and only happens with mad as mediahandler, but it is important to get fixed, so thanks for bringing it to our attention. I've put it in its own bug report: #20110.

Tomas Groth <tgc>In charge of this item.
Thu 07 Jun 2007 12:24:34 AM UTC, comment #1:

Well I've a compilation error with gcc4.1.2, mabe is it related :

/bin/sh ../libtool --tag=CXX --mode=link g++ -O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fomit-frame-pointer -march=i586 -mtune=generic -fasynchronous-unwind-tables -pthread -W -Wall -Wcast-align -Wcast-qual -Wpointer-arith -Wreturn-type -ldl -lltdl -lxml2 -lz -lm -lcurl -lboost_date_time -lboost_thread -lpthread -Wl,--as-needed -o gprocessor -export-dynamic -lltdl processor.o ../server/libgnashserver.la ../libbase/libgnashbase.la ../libamf/libgnashamf.la -lmad -lm -lglib-2.0 -lrt -lX11 -lXi -lm
../server/.libs/libgnashserver.so: undefined reference to `gnash::sound_handler::convert_raw_data(short*, int, void*, int, int, int, bool, int, bool)'
collect2: ld returned 1 exit status
make[2]: *** [gparser] Error 1
make[2]: *** Waiting for unfinished jobs....
../server/.libs/libgnashserver.so: undefined reference to `gnash::sound_handler::convert_raw_data(short*, int, void*, int, int, int, bool, int, bool)'
collect2: ld returned 1 exit status
make[2]: *** [dumpshm] Error 1
g++ -O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fomit-frame-pointer -march=i586 -mtune=generic -fasynchronous-unwind-tables -pthread -W -Wall -Wcast-align -Wcast-qual -Wpointer-arith -Wreturn-type -Wl,--as-needed -o .libs/gprocessor processor.o -Wl,--export-dynamic -L/usr/lib ../server/.libs/libgnashserver.so /home/eandry/rpm/BUILD/gnash/libamf/.libs/libgnashamf.so /home/eandry/rpm/BUILD/gnash/libgeometry/.libs/libgnashgeo.so /usr/lib/libxml2.so ../libbase/.libs/libgnashbase.so ../libamf/.libs/libgnashamf.so /home/eandry/rpm/BUILD/gnash/libbase/.libs/libgnashbase.so /usr/lib/libjpeg.so /usr/lib/libcurl.so /usr/lib/libidn.so -lssl -lcrypto -lz -lGL /usr/lib/libltdl.so -lboost_date_time -lboost_thread -lpthread /usr/lib/libmad.so /usr/lib/libglib-2.0.so -lrt /usr/lib/libXi.so /usr/lib/libXext.so /usr/lib/libX11.so /usr/lib/libXdmcp.so -ldl /usr/lib/libXau.so -lm
../server/.libs/libgnashserver.so: undefined reference to `gnash::sound_handler::convert_raw_data(short*, int, void*, int, int, int, bool, int, bool)'
collect2: ld returned 1 exit status
make[2]: *** [gprocessor] Error 1
make[2]: Leaving directory `/home/eandry/rpm/BUILD/gnash/utilities'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/eandry/rpm/BUILD/gnash'
make: *** [all] Error 2
error: Bad exit status from /home/eandry/rpm/tmp/rpm-tmp.88584 (%build)

Emmanuel Andry <eandry>
Wed 06 Jun 2007 07:56:22 PM UTC, original submission:

#0 0x0820dd53 in gnash::sound_handler::convert_raw_data (adjusted_data=0xb6a55344, adjusted_size=0xb6a55340, data=0x8a22c70, sample_count=50056,
sample_size=2, sample_rate=11025, stereo=false, m_sample_rate=44100, m_stereo=true) at /home/strk/src/gnash/gnash-head/backend/sound_handler.cpp:143
143 out_data++ = in;

Movie: http://foo.keybit.net/~strk/tmp/568db6323c3109f.swf
Renderer: agg GUI: gtk Media handler: ffmpeg

#0 0x0820dd53 in gnash::sound_handler::convert_raw_data (adjusted_data=0xb6a55344, adjusted_size=0xb6a55340, data=0x8a22c70, sample_count=50056,
sample_size=2, sample_rate=11025, stereo=false, m_sample_rate=44100, m_stereo=true) at /home/strk/src/gnash/gnash-head/backend/sound_handler.cpp:143
#1 0x0820c8a0 in SDL_sound_handler::create_sound (this=0x8724070, data=0x8a22c70, data_bytes=31313, sample_count=50056,
format=gnash::sound_handler::FORMAT_NATIVE16, sample_rate=11025, stereo=false) at /home/strk/src/gnash/gnash-head/backend/sound_handler_sdl.cpp:98
#2 0x081a72cc in gnash::SWF::tag_loaders::define_sound_loader (in=0x8883fd8, tag=gnash::SWF::DEFINESOUND, m=0x8883de0)
at /home/strk/src/gnash/gnash-head/server/swf/tag_loaders.cpp:1100
#3 0x081856d9 in gnash::movie_def_impl::read_all_swf (this=0x8883de0) at /home/strk/src/gnash/gnash-head/server/parser/movie_def_impl.cpp:889

Sandro Santilli <strk>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by tgc (Posted a comment)
  • -unavailable- added by eandry (Posted a comment)
  • -unavailable- added by strk (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 08 Jun 2007 06:20:21 AM UTCstrkStatusIn Progress=>Fixed
      Assigned tostrk=>tgc
      Open/ClosedOpen=>Closed
    Thu 07 Jun 2007 04:49:26 PM UTCstrkStatusNone=>In Progress
      Assigned totgc=>strk

    Back to the top


    Powered by Savane 3.1-cleanup1