bugGnash - The GNU Flash player - Bugs: bug #20012, FB: When pIxel format is not...

 
 

bug #20012: FB: When pIxel format is not supported (eg 8bit), gnash exits silently

Submitted by:  Martin Guy <martinwguy>
Submitted on:  Wed 30 May 2007 04:13:58 PM UTC  
 
Category: gui-fbSeverity: 2 - Minor
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Udo Giacomozzi <udog>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 11 Jul 2007 09:11:31 AM UTC, comment #5:

Fixed, please test.

Udo Giacomozzi <udog>
Project MemberIn charge of this item.
Thu 05 Jul 2007 06:43:08 PM UTC, comment #4:

For a quick hack using iostream (std::cerr <<) would do.

In the long term maybe log_error() should not rely on -v,
but worth asking on gnash-dev for other opinions.

Sandro Santilli <strk>
Project Member
Wed 04 Jul 2007 01:48:29 PM UTC, comment #3:

Ok, how do we usually print such error messages? printf?

Udo Giacomozzi <udog>
Project MemberIn charge of this item.
Wed 04 Jul 2007 11:45:33 AM UTC, comment #2:

> Do you expect an error message that's visible without the -v option?


Yes.

Silent failure is confusing to beginners and to people trying Gnash out for the first time; they do not know about -v and will likely just assume that "it doesn't work".

It is usual for -v to enable non-essential messages such as harmless warnings and verbose whistle-while-you-work stuff.
It is very unusual for its absence to suppress all console output including fatal error messages.

I don't know whether running in a reduced way on 8-bit FB would be better than nothing; maybe see what the mailing list thinks?
This bug's about the silent failure.

Martin Guy <martinwguy>
Wed 04 Jul 2007 07:20:17 AM UTC, comment #1:

Well, I see a error message:

19660] 17:09:17: ERROR: The pixel format of your framebuffer is not supported.

Do you expect an error message that's visible without the -v option?

8-bit Framebuffer is theoretically possible, but very difficult to carry out. Image quality would be very poor (fixed palette colors, uniform dithering at best) and I doubt anyone will every really need it (do you?). So there won't be any 8-bit support in the near future.

Another possibility would be to set a grayscale palette and work completely in grayscale, which would be relatively easy to do.

Udo Giacomozzi <udog>
Project MemberIn charge of this item.
Wed 30 May 2007 04:13:58 PM UTC, original submission:

When the FB depth is set to 8 bits per pixel,
Gnash AGG-FB exits immediately and silently.

-v makes it say:

19660] 17:09:17: Framebuffer device uses 8384512 bytes of memory.
19660] 17:09:17: Video mode: 1024x768 with 8 bits per pixel.
...
19660] 17:09:17: red channel: 0 / 8
19660] 17:09:17: green channel: 0 / 8
19660] 17:09:17: blue channel: 0 / 8
19660] 17:09:17: Total bits per pixel: 8
19660] 17:09:17: ERROR: The pixel format of your framebuffer is not supported.
19660] 17:09:17: Closing framebuffer device

whereas a working framebuffer says:

27475] 17:11:04: Video mode: 1024x768 with 16 bits per pixel.
27475] 17:11:04: Double buffering enabled
27475] 17:11:04: red channel: 11 / 5
27475] 17:11:04: green channel: 5 / 6
27475] 17:11:04: blue channel: 0 / 5
27475] 17:11:04: Total bits per pixel: 16

Assuming that 8-bit colour rendering is out :) an error message would be nicer.

Martin Guy <martinwguy>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by udog (Posted a comment)
  • -unavailable- added by strk (Updated the item)
  • -unavailable- added by martinwguy (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 12 Jul 2007 01:34:47 PM UTCmartinwguyStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Wed 11 Jul 2007 09:11:31 AM UTCudogStatusNone=>Ready For Test
    Tue 03 Jul 2007 01:31:15 AM UTCstrkAssigned toNone=>udog
    Wed 30 May 2007 08:23:31 PM UTCmartinwguyCategoryrender-agg=>gui-fb
      SummaryATI FB pIxel format misdetected/not supported=>FB: When pIxel format is not supported (eg 8bit), gnash exits silently

    Back to the top


    Powered by Savane 3.1-cleanup1