bugGnash - The GNU Flash player - Bugs: bug #19828, DrawingApiTestRunner fails...

 
 

bug #19828: DrawingApiTestRunner fails rendering tests

Submitted by:  Sandro Santilli <strk>
Submitted on:  Tue 08 May 2007 06:47:42 PM UTC  
 
Category: render-aggSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Udo Giacomozzi <udog>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 29 May 2007 08:49:05 AM UTC, comment #4:

Should be fixed now, please test.

Udo Giacomozzi <udog>
Project MemberIn charge of this item.
Wed 09 May 2007 07:58:07 AM UTC, comment #3:

I think this is a little bug in AGG backend. When you draw a line at 180, the line should appear at 180.

As said, I think I know the reason. Just can't check this right now (lack of time), but don't close this yet

Udo Giacomozzi <udog>
Project MemberIn charge of this item.
Tue 08 May 2007 10:14:22 PM UTC, comment #2:

I decided we're going to tolerate the one-pixel drift for now.
UdoG, if you think we shouldn't feel free to spend more time on it.

Sandro Santilli <strk>
Project Member
Tue 08 May 2007 10:00:31 PM UTC, comment #1:

To fix first failure, I verified that providing a radius of 2 to the check_pixel function we consistentily get the same "gray" value back when checking either 250,180 and 250,179. I think it's an acceptable value.

It is worth noting, though that the core lib does NOT consider point 250,179 as being over a character, while it does
for 250,180.

...Seems a detail to me actually...

Sandro Santilli <strk>
Project Member
Tue 08 May 2007 06:47:42 PM UTC, original submission:

FAILED: AGG_RGB24 pix:250,180 exp:0,0,0,255 obt:255,255,255,255 tol:2 [testsuite/misc-ming.all/DrawingApiTestRunner.cpp:119]

FAILED: AGG_RGB24 pix:146,225 exp:255,128,255,255 obt:254,132,254,255 tol:2 [testsuite/misc-ming.all/DrawingApiTestRunner.cpp:129]

The first is an 1-pixel thick orizontal line that seems to have been moved down (or is it up?) by a pixel.

The latter is the diagolan violet line, didn't check exact position
yet (should be easy by defining DEBUG_MOUSE_COORDINATES in gui.cpp).

This is after UdoG commit of today (2007-05-08)

Sandro Santilli <strk>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by udog (Posted a comment)
  • -unavailable- added by strk (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 29 May 2007 09:04:31 AM UTCudogStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Tue 08 May 2007 10:14:22 PM UTCstrkStatusNone=>Ready For Test

    Back to the top


    Powered by Savane 3.1-cleanup1