Wed 09 May 2007 09:55:33 AM UTC, comment #13:
I just committed a possible fix for the later problem.
Now MovieTester attempts to initialize an AGG renderer for each known pixel format. Tests welcome.
Only initializes RGB24 here as it seems render_handelr_agg.cpp
just forgets about the formats which are disabled at compile-time.
|
Wed 09 May 2007 09:50:41 AM UTC, comment #12:
Great, "make check" works again now, with pixel format set to RGB24(AGG+SDL).
"autogen.sh; ./configure ..; make clean; make check"
But with pixel format set to RGBA32, I could repeat UdoG's report.
|
Wed 09 May 2007 09:23:53 AM UTC, comment #11:
I guess you just have to drop the assertion at line 2063...
I'm working at adding a renderer for each pixelformat
|
Wed 09 May 2007 09:21:37 AM UTC, comment #10:
(and remember you can choose more than one pixel format)
|
Wed 09 May 2007 09:21:24 AM UTC, comment #9:
Beside, if more then a single pixel format is supported I think we should be initializing a renderer for each. At least this is what MovieTester has been implemented to support.
And not supporting a single pixelformat should NOT result
in a 'make check' failure, even if NO renderer were initialized
due to that.
|
Wed 09 May 2007 09:20:45 AM UTC, comment #8:
Have a look at the very bottom of render_handler_agg.cpp
|
Wed 09 May 2007 09:19:30 AM UTC, comment #7:
What's the macro name I can use to select the pixel format choosen at configuration time ?
|
Wed 09 May 2007 09:15:37 AM UTC, comment #6:
I don't know why you use RGB24 for the testsuite. I guess you simply picked one pixel format.
RGB24 is built always when using GTK GUI.
|
Wed 09 May 2007 09:00:56 AM UTC, comment #5:
I can't remember, why do we always use rgb24 instead of using
whatever gnash was built for ?
|
Wed 09 May 2007 08:09:37 AM UTC, comment #4:
I /think/ it works now, but I'm still unable to full run through "make check".
In this case I now why it aborts: I built Gnash for the FB backend with 32 bit pixel format only. The testsuite tries to create a AGG renderer instance for 24 bits (fixed for GTK). So, the testcase would have to use another pixel format or skip the test if RGB24 is not available.
make[3]: Entering directory `/mnt/bigdrive/home/udo/gnash/testsuite/samples'
Making a new site.exp file...
WARNING: could not find `runtest'
Movie file:///mnt/bigdrive/home/udo/gnash/testsuite/samples/clip_as_button2.swf (SWF7) added to library
Base url set to: file:///mnt/bigdrive/home/udo/gnash/testsuite/samples/clip_as_button2.swf
Scanning directory "/usr/local/lib/gnash/plugins" for plugins
ERROR: Can't open directory /usr/local/lib/gnash/plugins
framebuffer pixel format is RGB24
ERROR: Unknown pixelformat: RGB24
lt-clip_as_button2-TestRunner: render_handler_agg.cpp:2063: gnash::render_handler_agg_base* gnash::create_render_handler_agg(char*): Assertion `0' failed.
make[3]: *** [check-DEJAGNU] Error 134
make[3]: Leaving directory `/mnt/bigdrive/home/udo/gnash/testsuite/samples'
make[2]: *** [check-am] Error 2
make[2]: Leaving directory `/mnt/bigdrive/home/udo/gnash/testsuite/samples'
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory `/mnt/bigdrive/home/udo/gnash/testsuite'
|
Tue 08 May 2007 09:26:39 PM UTC, comment #3:
Fixed (hopefully).
autogen.sh; ./configure ..; make clean; # needed
|
Tue 08 May 2007 08:59:00 PM UTC, comment #2:
Cool, I could reproduce with boost 1.33 myself :)
FAIL: clip_as_button2-TestRunner died prematurely (SIGABRT)
FAIL: gotoFrameOnKeyEvent-TestRunner died prematurely (SIGABRT)
This was after I switched from --disable-shared to shared build,
so might be related to Makefile bugs (ie: not properly cleaning)
|
Tue 08 May 2007 03:36:26 PM UTC, comment #1:
I can't reproduce here, with boost 1.33.
Can anyone do with a boost > 1.32 ?
|
Tue 08 May 2007 03:29:09 PM UTC, original submission:
When running "make check" I always get the same assertion failure:
PASSED: AGG_RGB24 pix:434,291 exp:255,255,102,255 obt:255,255,102,255 tol:1 [clip_as_button2-TestRunner.cpp:229]
PASSED: string(text->get_text_value()) == [clip_as_button2-TestRunner.cpp:230]
lt-clip_as_button2-TestRunner: ../../libbase/ref_counted.h:61: void gnash::ref_counted::drop_ref() const: Assertion `m_ref_count > 0' failed.
make[3]: *** [check-DEJAGNU] Error 134
make[3]: Leaving directory `/mnt/bigdrive/home/udo/gnash/testsuite/samples'
make[2]: *** [check-am] Error 2
make[2]: Leaving directory `/mnt/bigdrive/home/udo/gnash/testsuite/samples'
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory `/mnt/bigdrive/home/udo/gnash/testsuite'
make: *** [check-recursive] Error 1
|