bugGnash - The GNU Flash player - Bugs: bug #19779, Better unknown sound format...

 
 

bug #19779: Better unknown sound format reporting

Submitted by:  Andrew Guertin <dolphinling>
Submitted on:  Thu 03 May 2007 03:21:47 AM UTC  
 
Category: soundSeverity: 3 - Normal
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Sandro Santilli <strk>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 03 May 2007 06:00:01 AM UTC, comment #1:

Applied, using log_unimpl for unimplemented warnings.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Thu 03 May 2007 03:21:47 AM UTC, original submission:

This patch does 4 things:

Makes Nellymoser not an "unknown" format in the error message, just unsupported,

Makes GST's unknown format error message better (copied SDL's),

Adds an assertion that ADPCM and UNCOMPRESSED should never be passed to the sound handler,

Adds a comment to sound_handler.h

It compiles and in my (very limited) testing has the desired effect without causing any problems.

Andrew Guertin <dolphinling>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #12677:  gnash_sound_patch added by dolphinling (3KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by martinwguy (Updated the item)
  • -unavailable- added by strk (Updated the item)
  • -unavailable- added by dolphinling (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 08 May 2007 10:45:39 PM UTCmartinwguyStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Thu 03 May 2007 06:00:01 AM UTCstrkStatusNone=>Ready For Test
      Assigned totgc=>strk
    Thu 03 May 2007 05:53:22 AM UTCstrkAssigned toNone=>tgc
    Thu 03 May 2007 03:21:47 AM UTCdolphinlingAttached File-=>Added gnash_sound_patch, #12677

    Back to the top


    Powered by Savane 3.1-cleanup1