bugGNUstep - Bugs: bug #19761, NSSecureTextField does not draw...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #19761: NSSecureTextField does not draw bullets

Submitted by:  -Deleted Account- <yjchen>
Submitted on:  Mon 30 Apr 2007 11:11:31 PM UTC  
 
Category: Gui/AppKitSeverity: 3 - Normal
Item Group: BugStatus: Fixed
Privacy: PublicAssigned to: Gregory John Casamento <gcasa>
Open/Closed: Closed

Sun 09 Nov 2008 03:20:57 PM UTC, comment #3:

Applied and tested. It works very well. If we can, at a later date, use a glyph generator for this (which I believe is the right solution) then we should replace it. Until then, this solution should suffice.

Thanks Saso & Fred.

Gregory John Casamento <gcasa>
Project AdministratorIn charge of this item.
Sun 09 Nov 2008 12:07:17 AM UTC, comment #2:

Added the patch from Saso, plus the email discussion. Feel free to apply the patch, as I never get around to write a special glyph generator for this.

Fred

It's primarily meant to just replace the stars with real bullets. The
fact that it may perform faster is near to no meaning, given the
typically tiny data set being manipulated.

--
Saso

Fred Kiefer wrote:

> > Hi Saso,
> >
> > thank you for this patch. It just arrived a few weeks to late :-)
> > I recently implemented the needed behaviour on GSLayoutManager and
> > NSGlyphGenerator. Now we are able to use a specific glyph generator
> > for the secure text fields. I just wanted to wait some time with
> > implementing this until the code in NSGlyphGenerator has gotten better
> > tested, otherwise I may have to revert this change.
> >
> > What I did not understand about your patch was the first bit where you
> > changed the generation of the replacement string. Is your code just a
> > bit faster or is there any other reason for the change? OK, you use a
> > bullet instead of a star. Is it that? I am asking, as this part of the
> > patch is still relevant.
> >
> > Fred
> >
> > Saso Kiselkov wrote:
>> >> Hi
>> >>
>> >> I've prepared a simple patch which implements bullet echoing in secure
>> >> text fields. It's a done in a rather stupid way, but it's functional.
>> >>
>> >> Regards
>> >> --
>> >> Saso
>> >>

(file #16803)

Fred Kiefer <FredKiefer>
Project Member
Sat 08 Nov 2008 11:34:59 PM UTC, comment #1:

Fred,

I recall there was a patch for this, but it was postponed since there were changes pending to the text system. What's the current status of the text system changes?

GC

Gregory John Casamento <gcasa>
Project AdministratorIn charge of this item.
Mon 30 Apr 2007 11:11:31 PM UTC, original submission:

NSSecureTextField has no implementation for -setEchosBullets:.
It is commented in the source code, too.

-Deleted Account- <yjchen>

 

Attached Files
file #16803:  bullet.patch added by FredKiefer (3KiB - text/x-diff - Saso's original patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by FredKiefer (Updated the item)
  • -unavailable- added by gcasa (Updated the item)
  • -unavailable- added by yjchen (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 09 Nov 2008 03:20:57 PM UTCgcasaStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Sun 09 Nov 2008 12:07:17 AM UTCFredKieferAttached File-=>Added bullet.patch, #16803
    Sat 19 May 2007 03:49:23 PM UTCgcasaStatusNone=>In Progress
      Assigned toNone=>gcasa

    Back to the top


    Powered by Savane 3.1-cleanup1