bugGnash - The GNU Flash player - Bugs: bug #19760, array elements should be normal...

 
 

bug #19760: array elements should be normal properties

Submitted by:  Sandro Santilli <strk>
Submitted on:  Mon 30 Apr 2007 05:04:42 PM UTC  
 
Category: ActionScriptSeverity: 4 - Important
Release: NoneStatus: Fixed
Privacy: PublicAssigned to: Benjamin Wolsey <bwy>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Tue 20 Oct 2009 03:38:42 PM UTC, comment #6:

Yep.

Benjamin Wolsey <bwy>
Project MemberIn charge of this item.
Fri 16 Oct 2009 04:38:05 PM UTC, comment #5:

Closer, right ?

Sandro Santilli <strk>
Project Member
Thu 15 Oct 2009 04:24:50 PM UTC, comment #4:

Now all array methods work with normal properties more or less as expected, but they are still not normal properties for arrays.

The remaining problem for most cases is the length property, which should only be set for genuine arrays (as far as I've been able to discover). The length property of a normal object is always (except in Array.splice) left alone. It would be easy to implement as a kind of hack by checking whether an object really is an array, but there may be a more elegant solution.

Of course, it's possible it's an ugly hack in the pp too.

Another problem is isStrict(), which is only used for AMF.

Benjamin Wolsey <bwy>
Project MemberIn charge of this item.
Thu 18 Sep 2008 06:55:17 AM UTC, comment #3:

FYI: visitProperty was made virtual and array implemented it
so for SharedObject we're kind of fine.

Except array properties don't support property flags
and order is not controlled. Still needed to turn them
into proper properties..

Sandro Santilli <strk>
Project Member
Wed 10 Sep 2008 12:09:24 AM UTC, comment #2:

Found another problematic case.
For SharedObject we need to scan the properties of an object
for serialization purpose. The as_object::visitPropertyValues
will fail to scan array properties if they are non-standard one.

Sandro Santilli <strk>
Project Member
Tue 29 Jan 2008 10:47:42 PM UTC, comment #1:

See bug #21788 for more related issues.

Sandro Santilli <strk>
Project Member
Mon 30 Apr 2007 05:04:42 PM UTC, original submission:

Rather then overriding set_member() and get_member, array properties should just be normal properties.
Tests for this are in the array.as file.

Sandro Santilli <strk>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bwy (Posted a comment)
  • -unavailable- added by strk (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 20 Oct 2009 03:38:42 PM UTCbwyOpen/ClosedOpen=>Closed
      StatusIn Progress=>Fixed
    Fri 16 Oct 2009 04:38:05 PM UTCstrkStatusNone=>In Progress
      Assigned toNone=>bwy
    Tue 29 Jan 2008 10:47:42 PM UTCstrkSeverity2 - Minor=>4 - Important
      Assigned tometeoryte=>None
    Sun 02 Sep 2007 08:12:52 PM UTCstrkAssigned toNone=>meteoryte
    Fri 25 May 2007 01:54:51 PM UTCstrkSeverity3 - Normal=>2 - Minor

    Back to the top


    Powered by Savane 3.1-cleanup1