bugfindutils - Bugs: bug #19616, leaf optimisation and loop...

 
 

bug #19616: leaf optimisation and loop detection broken in 4.3.3

Submitted by:  James Youngman <jay>
Submitted on:  Tue 17 Apr 2007 09:00:32 AM UTC  
 
Category: findSeverity: 4 - Important
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: James Youngman <jay>
Originator Name: Open/Closed: Closed
Release: 4.3.3Fixed Release: 4.3.4

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 17 Apr 2007 09:00:32 AM UTC, original submission:

In find.c, we have this code around line 1164:

/* Now we really need to stat the directory, even if we know the
* type, because we need information like struct stat.st_rdev.
*/
if (0 == stat_buf.st_mode)
{
/* This call was made conditional on Sat Apr 14 16:01:01 2007,
* and at that time the test suite passed without it. Omitting
* this stat call saves a lot of system calls.
*/
if (get_statinfo(pathname, name, &stat_buf) != 0)
return 0;

state.have_stat = true;
}

The conditional nature of that code is incorrect; the function goes on to use stat_buf.st_rdev assuming it is valid. and stat_buf.st_nlinks is used later too. This probably breaks the leaf optimisation and loop detection.

James Youngman <jay>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jay (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 21 Apr 2007 01:52:45 PM UTCjayFixed ReleaseNone=>4.3.4
    Sat 21 Apr 2007 01:52:44 PM UTCjayOpen/ClosedOpen=>Closed
    Tue 17 Apr 2007 09:05:18 AM UTCjayStatusNone=>Fixed

    Back to the top


    Powered by Savane 3.1-cleanup1