bugPSPP - Bugs: bug #19335, Get rid of warnings in perl scripts

 
 

bug #19335: Get rid of warnings in perl scripts

Submitted by:  John Darrington <jmd>
Submitted on:  Sun 18 Mar 2007 06:17:49 AM UTC  
 
Category: Compilation/PortabilitySeverity: 1 - Wishlist
Status: FixedAssigned to: Ben Pfaff <blp>
Open/Closed: ClosedRelease: None
Effort: 0.00

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 18 Jul 2007 03:21:17 AM UTC, comment #4:

Thanks for review. I checked this in.

Ben Pfaff <blp>
Project AdministratorIn charge of this item.
Fri 13 Jul 2007 12:53:46 AM UTC, comment #3:

Seems to work fine for me.

John Darrington <jmd>
Project Administrator
Thu 12 Jul 2007 12:51:36 AM UTC, comment #2:

This patch standardizes on "use strict; use warnings 'all';" for all the Perl scripts I could find in the source tree and fixes the warnings that it produces. As part of that I greatly simplified the get-commands.pl parsing, although it's probably harder to read now. I also made get-commands.pl add an "End:" line to the Emacs mode comment that it produces, without which Emacs gives a warning when I open ni.texi.

(file #13289)

Ben Pfaff <blp>
Project AdministratorIn charge of this item.
Sun 18 Mar 2007 04:15:41 PM UTC, comment #1:

Making them clean on "use strict" is good too.

Ben Pfaff <blp>
Project AdministratorIn charge of this item.
Sun 18 Mar 2007 06:17:49 AM UTC, original submission:

We should make the perl scripts run without complaining, when run with perl -w . This will mean lower probability of portability problems and perl version problems.

John Darrington <jmd>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #13289:  perl-warning-avoidance.patch added by blp (7KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by blp (Posted a comment)
  • -unavailable- added by jmd (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 18 Jul 2007 03:21:17 AM UTCblpStatusReady for Test/Review=>Fixed
      Open/ClosedOpen=>Closed
    Fri 13 Jul 2007 12:53:46 AM UTCjmdAssigned toNone=>blp
    Thu 12 Jul 2007 12:51:36 AM UTCblpStatusNone=>Ready for Test/Review
    Thu 12 Jul 2007 12:51:35 AM UTCblpAttached File-=>Added perl-warning-avoidance.patch, #13289

    Back to the top


    Powered by Savane 3.1-cleanup1