bugGnash - The GNU Flash player - Bugs: bug #19230, [PATCH] safety check for...

 
 

bug #19230: [PATCH] safety check for kill(-1,SIGTERM)

Submitted by:  Robert Millan <robertmh>
Submitted on:  Wed 07 Mar 2007 02:21:54 PM UTC  
 
Category: pluginSeverity: 3 - Normal
Release: NoneStatus: None
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 07 Mar 2007 07:35:23 PM UTC, comment #2:

Sorry, I realized right after submitting and found no way of moving it to "patches".

Thanks for appliing. And keep up the good work!

Robert Millan <robertmh>
Wed 07 Mar 2007 07:04:25 PM UTC, comment #1:

I've committed this patch to HEAD.

Please consider posting patches in the 'patches' section rather than the 'bugs' one.

Thanks for the patch!

Bastiaan Jacques <bjacques>
Project Member
Wed 07 Mar 2007 02:21:54 PM UTC, original submission:

Please consider this check to be fault-tollerant and prevent kill(-1,SIGTERM) in case something fubarred _childpid.

diff -u -r1.72 plugin.cpp
--- plugin/plugin.cpp 6 Mar 2007 18:06:12 -0000 1.72
+++ plugin/plugin.cpp 7 Mar 2007 14:15:39 -0000
@@ -295,7 +295,7 @@
void
nsPluginInstance::shut()
{
- if (_childpid) {
+ if (_childpid > 0) {
// it seems that waiting after a SIGINT hangs firefox
// IFF not run from the console (see bug #17082).
// SIGTERM instead solves this problem

Robert Millan <robertmh>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bjacques (Posted a comment)
  • -unavailable- added by robertmh (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 07 Mar 2007 07:04:35 PM UTCbjacquesOpen/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1